-
-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Deprecate svelte field in package.json #7489
Conversation
🦋 Changeset detectedLatest commit: 099dd34 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
If we do that we need to make sure the rollup and webpack plugins still work correctly. How can we ensure that? |
de6810a
to
9787d4a
Compare
9787d4a
to
8102d9c
Compare
The Here's a test showing that the Rollup plugin works without the Here's some documentation showing which fields
|
related sveltejs/vite-plugin-svelte#482 That fixes the situation mostly with vps, but i'm still testing it. Perf can be a problem and also what happens with ssr.optimizeDeps. |
there are no .svelte files in that test directory, sure that's testing svelte resolve? i think it may just be fore the package.json export warning. |
You're right. It wasn't testing it. However, it does work. I just made a sample Rollup project using a node module with the following
|
The
svelte
field was originally intended to allow package authors to be able to provide uncompiled.svelte
files as well as a compiled.js
version. We have decided if packages would like to provide a compiled version that a better way to do this is to create sub-package such ascompiled
.The way the
svelte
field is currently implemented invite-plugin-svelte
breaks Vite's dependency optimization and we've decided removing support for thesvelte
field is the best path forward