-
-
Notifications
You must be signed in to change notification settings - Fork 2.1k
[fix] prevent unused types warning #6293
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
🦋 Changeset detectedLatest commit: 140b849 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Just realized it's also benefitial to add a ts-nocheck comment at the top of all of these, so in case there are type errors they don't show up twice. Will do that tomorrow on this PR. |
hahaha this is an incredible solution — i was thinking about walking the AST to see if the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
rescinding my approval, but only so i don't accidentally merge it before the no-check stuff gets added
This really does feel like we need type tests 😄 I don't know that we need to hold this up for tests since there's so much on our plates right now, but it might be nice to do post-summit |
I agree we need type tests, but this one isn't really related to that. It's a hidden file generated from the user's file, and there are already tests for it. |
Ah, I missed that there's a test because it was in the |
Fixes #6290
Please don't delete this checklist! Before submitting the PR, please make sure you do the following:
Tests
pnpm test
and lint the project withpnpm lint
andpnpm check
Changesets
pnpm changeset
and following the prompts. All changesets should bepatch
until SvelteKit 1.0