Skip to content

set errors on all layout/leaf components #6279

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 25, 2022
Merged

set errors on all layout/leaf components #6279

merged 1 commit into from
Aug 25, 2022

Conversation

Rich-Harris
Copy link
Member

fixes #6264. I got lazy and didn't add a test here, because this code is likely to get swept away after #5875, and it's unlikely to regress in the meantime

Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests

  • Run the tests with pnpm test and lint the project with pnpm lint and pnpm check

Changesets

  • If your PR makes a change that should be noted in one or more packages' changelogs, generate a changeset by running pnpm changeset and following the prompts. All changesets should be patch until SvelteKit 1.0

@changeset-bot
Copy link

changeset-bot bot commented Aug 25, 2022

🦋 Changeset detected

Latest commit: a017d0a

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@sveltejs/kit Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@Rich-Harris Rich-Harris merged commit 128340c into master Aug 25, 2022
@Rich-Harris Rich-Harris deleted the gh-6264 branch August 25, 2022 18:23
nnnnathann added a commit to nnnnathann/kit that referenced this pull request Aug 27, 2022
my page utilizing server actions was not receiving errors in
export let errors... until now!
Rich-Harris added a commit that referenced this pull request Aug 27, 2022
* set errors on root component - relates to #6279

my page utilizing server actions was not receiving errors in
export let errors... until now!

* Create funny-keys-appear.md

Co-authored-by: Rich Harris <hello@rich-harris.dev>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

+page.svelte in deepest route is not getting errors prop
2 participants