correctly determine whether a route uses server data #6275
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #6269
fixes #6258
fixes #6276
fixes #6257
Prior to this change, the logic for determining whether a given route uses server data (and therefore needs to hit
__data.json
on invalidation/navigation) was faulty if the only server data comes from a sibling+layout.server.js
.The test is a bit of a sleight-of-hand because there's already a parent
+layout.server.js
, so it was already being picked up. But I've tested this fix in a repro and it works correctly.Please don't delete this checklist! Before submitting the PR, please make sure you do the following:
Tests
pnpm test
and lint the project withpnpm lint
andpnpm check
Changesets
pnpm changeset
and following the prompts. All changesets should bepatch
until SvelteKit 1.0