Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[chore] fix flaky tests #5199

Merged
merged 3 commits into from
Jun 21, 2022
Merged

[chore] fix flaky tests #5199

merged 3 commits into from
Jun 21, 2022

Conversation

baseballyama
Copy link
Member

fix: #5001

I wrote what I did for each flaky test in the commit message.
So please check it out for details.

Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests

  • Run the tests with pnpm test and lint the project with pnpm lint and pnpm check

Changesets

  • If your PR makes a change that should be noted in one or more packages' changelogs, generate a changeset by running pnpm changeset and following the prompts. All changesets should be patch until SvelteKit 1.0

@baseballyama
fix 'navigating store clears after aborted navigatio'
99707d1 
this is because just forgotten await.
@baseballyama
fix 'renders error page for missing page' test
1ddb7ed 
I checked this test on chrome with network / cpu throttling.
Then I found that `count: 1` part is updated AFTER all resources are retrieved from the network.
So I added waiting process until networkidle.
@baseballyama
fix 'does not attempt client-side navigation to server routes'
4b55080 
Test on chrome with CPU / network throttling, then it seems to be a lag between the navigation complete and rendering of the "ok".
To solve this, I used `waitForLoadState` to wait until all network communication is complete.

refer: https://playwright.dev/docs/navigations#custom-wait-1
@changeset-bot
Copy link

changeset-bot bot commented Jun 12, 2022

⚠️ No Changeset found

Latest commit: 4b55080

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@Rich-Harris Rich-Harris merged commit aefefef into sveltejs:master Jun 21, 2022
@Rich-Harris
Copy link
Member

yesssss ❤️

This was referenced Jun 23, 2022
Closed
Closed
@baseballyama baseballyama deleted the chore/flaky-test branch June 23, 2022 06:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Rich-Harris Rich-Harris Rich-Harris approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Flaky tests
2 participants
@baseballyama @Rich-Harris