Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs] improve documentation for new developers #5154

Merged
merged 4 commits into from
Jun 3, 2022
Merged

Conversation

benmccann
Copy link
Member

Adds code comments to help new devs around the codebase. I didn't add comments for methods where I felt the name would be self-explanatory, but tried to comment a lot of the more important methods whose functioning might be more complicated.

CC @gtm-nayan - feel free to let me know if there are others you'd like me to add here

@benmccann benmccann added the documentation Improvements or additions to documentation label Jun 3, 2022
@changeset-bot
Copy link

changeset-bot bot commented Jun 3, 2022

⚠️ No Changeset found

Latest commit: 4f427e8

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

packages/kit/src/core/build/utils.js Outdated Show resolved Hide resolved
packages/kit/src/core/config/index.js Outdated Show resolved Hide resolved
packages/kit/src/core/config/index.js Outdated Show resolved Hide resolved
benmccann and others added 3 commits June 3, 2022 13:41
Co-authored-by: Rich Harris <richard.a.harris@gmail.com>
Co-authored-by: Rich Harris <richard.a.harris@gmail.com>
Co-authored-by: Rich Harris <richard.a.harris@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants