disable local playwright tracing by default

[mrkishi]

This PR disables playwright tracing on local e2e tests unless process.env.TRACE is enabled. Tracing has a performance impact, so it makes sense to only trace tests when we're interested in them.

An alternative would be to enable retries locally and use trace: 'on-first-retry' instead. This would be valuable if the majority of contributors use traces as a first debugging step, otherwise requiring manual activation (ie. this pr) might be best.

Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

• It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
• This message body should clearly illustrate what problems it solves.
• Ideally, include a test that fails without this PR but passes with it.

Tests

• Run the tests with pnpm test and lint the project with pnpm lint and pnpm check

Changesets

• If your PR makes a change that should be noted in one or more packages' changelogs, generate a changeset by running pnpm changeset and following the prompts. All changesets should be patch until SvelteKit 1.0

[changeset-bot]

⚠️ No Changeset found

Latest commit: 92d416a

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

[dominikg]

If trace on retry is used, the result archiving needs to be updated to include retried results. They are currently filtered to keep the archive smaller

kit/.github/workflows/ci.yml

Line 48 in 4592b76

- name: archive test results

[mrkishi]

This was only about local tests. Do you believe we should move CI from retain-on-failure to on-first-retry? I'm not sure it's a good deal, having tracing always enabled on CI might even surface timing-sensitive errors we miss locally due to the different execution.

[dominikg]

oh, i thought you wanted to speed up CI too with the comment about on-first-retry.