Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: lint pipeline automatically formats files, misses errors in CI #5021

Conversation

elliott-with-the-longest-name-on-github
Copy link
Contributor

Every time I try to make a PR that changes packages/kit it tries to reformat the paths-base/svelte.config.js file. I figured this was some weird mis-cached formatting issue, so I ran turbo lint --force to bypass caching and see if there were any other mis-formatted things. Looks like there was one in adapter-vercel.

Note that running turbo check --force also fails, but I couldn't figure out what was causing it and I didn't have time to dig into it any further.

If this is some weird configuration issue on my end, feel free to just close the PR and forget about it.

Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests

  • Run the tests with pnpm test and lint the project with pnpm lint and pnpm check

Changesets

  • If your PR makes a change that should be noted in one or more packages' changelogs, generate a changeset by running pnpm changeset and following the prompts. All changesets should be patch until SvelteKit 1.0

@changeset-bot
Copy link

changeset-bot bot commented May 21, 2022

⚠️ No Changeset found

Latest commit: 54e9b92

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@mrkishi
Copy link
Member

mrkishi commented May 22, 2022

This PR prompted further questions that made me realize we have a broken lint step: it runs format before linting, so any issues that are fixed automatically by format go undetected in CI.

I pushed a change to drop the unwanted format from lint, but added an autolint script that keeps the old behavior since that's useful during dev.

@mrkishi
Copy link
Member

mrkishi commented May 22, 2022

I had to merge in master since, case in point, it introduced another missed lint error.

@mrkishi mrkishi changed the title fix: Incorrectly-cached formatting fix: lint pipeline automatically formats files, misses errors in CI May 22, 2022
@Rich-Harris
Copy link
Member

thanks!

@elliott-with-the-longest-name-on-github elliott-with-the-longest-name-on-github deleted the sejohnson-fix-bad-formatting branch May 23, 2022 16:15
@Rich-Harris Rich-Harris mentioned this pull request May 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants