WebKit tests #4847
Merged
WebKit tests #4847
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test: "prevents navigation triggered by back button" False positive? Yes Reason for failure: The browsers block attempts to prevent navigation on a frame that's never had a user gesture.
False positive? Yes Reason for failure: Test checked for chrome specific error page.
Test: "client-side error from load() is malformed" False positive? Yes Reason for failure: The test matched error.stack instead of error.message and WebKit doesn't show the message as the first line of the stack trace
Tests: 1. 'resets focus' 2. 'focus works if page load has hash' 3. 'focus works when navigating to a hash on the same page' False positives? Yes Reason for failure: "Press tab to highlight each item on a webpage" accessibility setting is turned off in Playwright. Need to use Alt+Tab for WebKit instead.
Test: "includes correct page request headers" False positive? Yes Reason for failure: Test targeted headers that Safari doesn't support.
Test: "should load stuff after reloading by goto" False positive? Yes Reason for failure: module flag wasn't reset between playwright runs
|
Rich-Harris
approved these changes
May 11, 2022
|
thank you! |
5 tasks
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While writing a test for a Safari only bug (PR #4846), the test suite exposed 13 false positives originating from browser specific behavior in the tests. This PR slightly tweaks the integration tests to be more browser agnostic and allows them to be run using WebKit. It doesn’t include changes to the Playwright config, so the WebKit tests would still be completely opt-in.
Tests changed and reasons for WebKit false positives:
"includes correct page request headers"
Test targeted headers that Safari doesn't support
1. "resets focus"
2. "focus works if page load has hash"
3. "focus works when navigating to a hash on the same page"
"Press tab to highlight each item on a webpage" accessibility setting is turned off in Playwright. Need to use Alt+Tab for WebKit instead.
"client-side error from load() is malformed"
The test matched error.stack instead of error.message and WebKit doesn't show the message as the first line of the stack trace
"prevents redirect loops"
Test checked for chrome specific error page.
"prevents navigation triggered by back button"
The browsers block attempts to prevent navigation on a frame that's never had a user gesture.
"should load stuff after reloading by goto"
Module flag wasn't reset between playwright runs
Please don't delete this checklist! Before submitting the PR, please make sure you do the following:
Tests
pnpm testand lint the project withpnpm lintandpnpm checkChangesets
pnpx changesetand following the prompts. All changesets should bepatchuntil SvelteKit 1.0