Skip to content

Conversation

@rmunn
Copy link
Contributor

@rmunn rmunn commented Apr 7, 2022

Because of how #4345 was merged into #4344, the script that automatically adds PR numbers to the changelog got the wrong PR number for the "Expose event.routeId and page.routeId" feature. This manual change to the CHANGELOG.md file fixes that minor error.

No changeset included, for obvious reasons.

Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests

  • Run the tests with pnpm test and lint the project with pnpm lint and pnpm check

Changesets

  • If your PR makes a change that should be noted in one or more packages' changelogs, generate a changeset by running pnpx changeset and following the prompts. All changesets should be patch until SvelteKit 1.0

Because of how sveltejs#4345 was merged into sveltejs#4344, the script that automatically
adds PR numbers to the changelog got the wrong PR number for the "Expose
`event.routeId` and `page.routeId`" feature. This manual change to 
the CHANGELOG.md file fixes that minor error.
@changeset-bot
Copy link

changeset-bot bot commented Apr 7, 2022

⚠️ No Changeset found

Latest commit: 8c5f280

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Fix link destination as well as link text

Co-authored-by: Ignatius Bagus <ignatius.mbs@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants