Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

2697: add base and asset transform to html template 🦎 #3088

Closed
wants to merge 1 commit into from
Closed

2697: add base and asset transform to html template 🦎 #3088

wants to merge 1 commit into from

Conversation

dreitzner
Copy link
Contributor

@dreitzner dreitzner commented Dec 22, 2021 •
edited
Loading

Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests

  • Run the tests with pnpm test and lint the project with pnpm lint and pnpm check

Changesets

  • If your PR makes a change that should be noted in one or more packages' changelogs, generate a changeset by running pnpx changeset and following the prompts. All changesets should be patch until SvelteKit 1.0

Changes

  • add transforms for paths (assets, base) to html
  • add info to migration guide
  • add info into config docs

closes #2697

@changeset-bot
Copy link

changeset-bot bot commented Dec 22, 2021

🦋 Changeset detected

Latest commit: 555814b

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@sveltejs/kit Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@Rich-Harris
Copy link
Member

Thank you. Adding assets definitely makes sense to me. Adding base could be a little bit tricky though, because we have ambitions to support dynamic basepaths — #595 — and that wouldn't work if we were writing the basepath into the HTML.

I think what we probably want to do is allow assets in the template...

<!DOCTYPE html>
<html lang="en">
  <head>
    <meta charset="utf-8" />
    <meta name="description" content="" />
-    <link rel="icon" href="/favicon.png" />
+    <link rel="icon" href="%svelte.assets%/favicon.png" />
    <meta name="viewport" content="width=device-width, initial-scale=1" />
    %svelte.head%
  </head>
  <body>
    <div id="svelte">%svelte.body%</div>
  </body>
</html>

...and then replace assets with paths.assets if it's set (in which case it's an absolute URL) and a relative path to the root otherwise. So / would look like this...

<link rel="icon" href="./favicon.png" />

...but /foo/bar/baz would look like this:

<link rel="icon" href="../../favicon.png" />

We'd also need to account for the trailingSlash option, since if /foo/bar/baz redirected to /foo/bar/baz/ it would be ../../.. rather than ../...

@Rich-Harris Rich-Harris mentioned this pull request Jan 7, 2022
Merged
5 tasks
@Rich-Harris
Copy link
Member

Closing in favour of #3234

@Rich-Harris Rich-Harris closed this Jan 7, 2022
@dreitzner dreitzner deleted the issue-2697-base-path-in-html-template branch November 14, 2022 07:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Generated URLs are inconsistent to the basepath with adapter-static
2 participants
@dreitzner @Rich-Harris