Skip to content

chore: run the cross-platform and async dev e2e legs on pushes only - #16861

Open
Nic-Polumeyv wants to merge 2 commits into
e2e-variantsfrom
e2e-variant-trim
Open

chore: run the cross-platform and async dev e2e legs on pushes only#16861
Nic-Polumeyv wants to merge 2 commits into
e2e-variantsfrom
e2e-variant-trim

Conversation

@Nic-Polumeyv

@Nic-Polumeyv Nic-Polumeyv commented Aug 20, 2026

Copy link
Copy Markdown
Contributor

Every pull request runs all 31 legs from #16845, about 110 runner-minutes against the org's 20 concurrent job cap (5 for macOS), so a burst of PRs queues longer than the jobs take. Two groups rarely change a PR's outcome: the six cross-platform legs (windows, firefox, webkit on macOS) and the three async dev legs, which exercise a compiler flag plus one define that behave the same in dev and build. The two resolution no-js legs duplicate the base no-js legs outright, since nothing requests __route.js without JS.

This drops the two duplicates and moves the nine others into an e2e-push job with if: github.event_name == 'push', sharing env and steps with e2e through YAML anchors (an exclude cannot filter an include-only matrix). A pull request runs 22 jobs, about 65 runner-minutes; a push to version-3 still runs everything. Listing the tests per matrix row with playwright test --list before and after shows no test is absent from every PR row, and every push-only test still runs on push.

e2e-push has only been observed skipping on pull_request runs; the first push after merge is the check that it materialises.

@pkg-svelte-dev

pkg-svelte-dev Bot commented Aug 20, 2026

Copy link
Copy Markdown

Install the latest version of @sveltejs/kit from cf06113:

pnpm add https://pkg.svelte.dev/@sveltejs/kit/c/cf061130658f0c9d3a3d137c26ca5f8d6f12e8db

Open in pkg.svelte.dev: https://pkg.svelte.dev/repos/kit/pr/16861

@changeset-bot

changeset-bot Bot commented Aug 20, 2026

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: cf06113

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@svelte-docs-bot

Copy link
Copy Markdown

@Nic-Polumeyv
Nic-Polumeyv force-pushed the e2e-variant-trim branch 2 times, most recently from 86357e3 to 406b388 Compare August 20, 2026 18:01
@Nic-Polumeyv
Nic-Polumeyv force-pushed the e2e-variant-trim branch 2 times, most recently from 791ba65 to cf06113 Compare August 20, 2026 18:37
@Nic-Polumeyv Nic-Polumeyv changed the title chore: trim the e2e variant legs chore: run the cross-platform and async dev e2e legs on pushes only Aug 21, 2026
@Nic-Polumeyv
Nic-Polumeyv marked this pull request as ready for review August 21, 2026 20:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant