chore: run the cross-platform and async dev e2e legs on pushes only - #16861
Open
Nic-Polumeyv wants to merge 2 commits into
Open
chore: run the cross-platform and async dev e2e legs on pushes only#16861Nic-Polumeyv wants to merge 2 commits into
Nic-Polumeyv wants to merge 2 commits into
Conversation
|
Install the latest version of pnpm add https://pkg.svelte.dev/@sveltejs/kit/c/cf061130658f0c9d3a3d137c26ca5f8d6f12e8dbOpen in |
|
Nic-Polumeyv
force-pushed
the
e2e-variant-trim
branch
2 times, most recently
from
August 20, 2026 18:01
86357e3 to
406b388
Compare
Nic-Polumeyv
force-pushed
the
e2e-variant-trim
branch
2 times, most recently
from
August 20, 2026 18:37
791ba65 to
cf06113
Compare
Nic-Polumeyv
marked this pull request as ready for review
August 21, 2026 20:08
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Every pull request runs all 31 legs from #16845, about 110 runner-minutes against the org's 20 concurrent job cap (5 for macOS), so a burst of PRs queues longer than the jobs take. Two groups rarely change a PR's outcome: the six cross-platform legs (windows, firefox, webkit on macOS) and the three
asyncdev legs, which exercise a compiler flag plus one define that behave the same in dev and build. The tworesolutionno-js legs duplicate the base no-js legs outright, since nothing requests__route.jswithout JS.This drops the two duplicates and moves the nine others into an
e2e-pushjob withif: github.event_name == 'push', sharingenvandstepswithe2ethrough YAML anchors (anexcludecannot filter an include-only matrix). A pull request runs 22 jobs, about 65 runner-minutes; a push toversion-3still runs everything. Listing the tests per matrix row withplaywright test --listbefore and after shows no test is absent from every PR row, and every push-only test still runs on push.e2e-pushhas only been observed skipping on pull_request runs; the first push after merge is the check that it materialises.