Repository navigation
chore: add failing tests for adapter-node - #16104
Merged
Merged
Conversation
|
teemingc
commented
Jun 20, 2026
![vercel[bot]](https://avatars.githubusercontent.com/in/8329?s=60&v=4){kind=small}
teemingc
changed the title
This reverts commit 4def670.
6 tasks done
Conduitry
reviewed
Jun 20, 2026
Member
teemingc
marked this pull request as draft
June 20, 2026 13:43
Member
Author
Member
Author
|
Ok, I've added a test for #16095 . It's a simple one that checks CSR is working since the JS assets would need to be resolved correctly. |
teemingc
marked this pull request as ready for review
June 22, 2026 05:59
This was referenced Jun 22, 2026
Contributor
|
@teemingc should we make this a platform test so that it doesn't always have to run for every PR? |
Rich-Harris
pushed a commit
that referenced
this pull request
Jun 22, 2026
closes #16090 closes #16096 This PR is an alternative to #16096 that reuses an existing pattern of storing the inlined variable in a constant and reusing that throughout the code. The added benefit is that we reduce the number of times the string literal appears in the build output. --- ### Please don't delete this checklist! Before submitting the PR, please make sure you do the following: - [x] It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs - [x] This message body should clearly illustrate what problems it solves. - [x] Ideally, include a test that fails without this PR but passes with it. - tests added in #16104 ### Tests - [x] Run the tests with `pnpm test` and lint the project with `pnpm lint` and `pnpm check` ### Changesets - [x] If your PR makes a change that should be noted in one or more packages' changelogs, generate a changeset by running `pnpm changeset` and following the prompts. Changesets that add features should be `minor` and those that fix bugs should be `patch`. Please prefix changeset messages with `feat:`, `fix:`, or `chore:`. ### Edits - [x] Please ensure that 'Allow edits from maintainers' is checked. PRs without this option may be closed.
Rich-Harris
pushed a commit
that referenced
this pull request
Jun 22, 2026
closes #16095 This PR adds a Rollup plugin to correct module relative paths. It worked previously because the `import.meta.url` code was called from a file at the root. However, bundling the entries caused Rollup to move it to a shared chunk which lived in a nested directory. The new plugin ensures that entries creating a relative URL resolves correctly to the root --- ### Please don't delete this checklist! Before submitting the PR, please make sure you do the following: - [x] It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs - [x] This message body should clearly illustrate what problems it solves. - [x] Ideally, include a test that fails without this PR but passes with it. - #16104 (comment) adds tests ### Tests - [x] Run the tests with `pnpm test` and lint the project with `pnpm lint` and `pnpm check` ### Changesets - [x] If your PR makes a change that should be noted in one or more packages' changelogs, generate a changeset by running `pnpm changeset` and following the prompts. Changesets that add features should be `minor` and those that fix bugs should be `patch`. Please prefix changeset messages with `feat:`, `fix:`, or `chore:`. ### Edits - [x] Please ensure that 'Allow edits from maintainers' is checked. PRs without this option may be closed.
Rich-Harris
added a commit
that referenced
this pull request
Jun 22, 2026
closes #16092 This PR tries to keep the benefits of #16069 while ensuring the Node adapter handler code and the user's server build output are in separate chunks. Doing so avoids the circular dependency that causes the app to crash on startup. --- ### Please don't delete this checklist! Before submitting the PR, please make sure you do the following: - [x] It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs - [x] This message body should clearly illustrate what problems it solves. - [x] Ideally, include a test that fails without this PR but passes with it. - see #16104 ### Tests - [x] Run the tests with `pnpm test` and lint the project with `pnpm lint` and `pnpm check` ### Changesets - [x] If your PR makes a change that should be noted in one or more packages' changelogs, generate a changeset by running `pnpm changeset` and following the prompts. Changesets that add features should be `minor` and those that fix bugs should be `patch`. Please prefix changeset messages with `feat:`, `fix:`, or `chore:`. ### Edits - [x] Please ensure that 'Allow edits from maintainers' is checked. PRs without this option may be closed. --------- Co-authored-by: Rich Harris <richard.a.harris@gmail.com> Co-authored-by: Rich Harris <rich.harris@vercel.com>
Member
|
The test failure looks legit btw |
Member
|
(they're related to #16114, which wasn't the correct fix AFAICT. Vercel bot actually clocked it earlier, but I thought it was a hallucination) |
Rich-Harris
approved these changes
Jun 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
related to #16092 and #16090 and #16095
This PR adds an adapter-node test app that fails due to the bugs from the issues above (both only observable after build). Also moves unit tests next to their related files.
Please don't delete this checklist! Before submitting the PR, please make sure you do the following:
Tests
pnpm testand lint the project withpnpm lintandpnpm checkChangesets
pnpm changesetand following the prompts. Changesets that add features should beminorand those that fix bugs should bepatch. Please prefix changeset messages withfeat:,fix:, orchore:.Edits