Skip to content

fix: avoid colliding with user-typed platform.env - #16043

Merged
Rich-Harris merged 5 commits into
mainfrom
fix-cloudflare-platform-type
Jun 15, 2026
Merged

Rich-Harris merged 5 commits into
mainfrom
fix-cloudflare-platform-type

Conversation

@teemingc

Copy link
Copy Markdown
Member

closes #16036

Ever since we moved the svelte config to the Vite config file, the user's adapter ambient.d.ts actually gets applied (good thing!). Unfortunately, our adapter's type of platform.env is preventing the user from declaring it themselves. This PR fixes that.


Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests

  • Run the tests with pnpm test and lint the project with pnpm lint and pnpm check

Changesets

  • If your PR makes a change that should be noted in one or more packages' changelogs, generate a changeset by running pnpm changeset and following the prompts. Changesets that add features should be minor and those that fix bugs should be patch. Please prefix changeset messages with feat:, fix:, or chore:.

Edits

  • Please ensure that 'Allow edits from maintainers' is checked. PRs without this option may be closed.

@changeset-bot

changeset-bot Bot commented Jun 14, 2026 •

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: dbd170e

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@sveltejs/adapter-cloudflare Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@svelte-docs-bot

Copy link
Copy Markdown

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG] platform.env bindings typed as unknown / duplicate Env declaration with adapter-cloudflare on SvelteKit 2.58.0+

2 participants