-
-
Notifications
You must be signed in to change notification settings - Fork 2.2k
chore(deps): update vitest monorepo to v4 (major) #14789
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
44e6ab3
12362f9
c79260b
3c4e6b1
ed96979
e240334
ebb766a
eabb0c8
87dd484
94f822c
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -2,7 +2,9 @@ import { assert, test, describe } from 'vitest'; | |
| import { get_pathname, parse_isr_expiration, pattern_to_src, resolve_runtime } from '../utils.js'; | ||
|
|
||
| // workaround so that TypeScript doesn't follow that import which makes it pick up that file and then error on missing import aliases | ||
| const { parse_route_id } = await import('../../kit/src/' + 'utils/routing.js'); | ||
| const { parse_route_id } = await import( | ||
| new URL('../../kit/src/' + 'utils/routing.js', import.meta.url).href | ||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Using the module location as a base helps resolve the correct path. Otherwise, it errors with Vitest 4. This wouldn't happen if we weren't concatenating the path string. But we need to do that to prevent TypeScript from type checking the imported file which contains references to kit types that are not aliased in this package |
||
| ); | ||
|
|
||
| /** | ||
| * @param {import('@sveltejs/kit').RouteDefinition<any>['segments']} segments | ||
|
|
||
This file was deleted.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Vitest seems to be strict about explicitly specifying relative paths vs package names