Skip to content

Conversation

PatrickG
Copy link
Member

@PatrickG PatrickG commented Oct 18, 2025

Fixes #14496 and probably #14713

When a fast and a slower load function both return a promise, the count in create_async_iterator could have reached 0 before the slower load function returns. Which means the promise of the slower load function is .add()ed after the done-promise resolves.
This makes sure the done-promise only resolves after the iterator has been accessed. At that point all .add() calls have been made. This gets rid of the count var in favor of a simpler implementation.


Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests

  • Run the tests with pnpm test and lint the project with pnpm lint and pnpm check

Changesets

  • If your PR makes a change that should be noted in one or more packages' changelogs, generate a changeset by running pnpm changeset and following the prompts. Changesets that add features should be minor and those that fix bugs should be patch. Please prefix changeset messages with feat:, fix:, or chore:.

Edits

  • Please ensure that 'Allow edits from maintainers' is checked. PRs without this option may be closed.

Copy link

changeset-bot bot commented Oct 18, 2025

🦋 Changeset detected

Latest commit: 8192a4f

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@sveltejs/kit Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@svelte-docs-bot
Copy link

@PatrickG PatrickG requested a review from Rich-Harris October 18, 2025 20:33
Copy link
Member

@Rich-Harris Rich-Harris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

neat!

@Rich-Harris Rich-Harris merged commit fc6017c into sveltejs:main Oct 19, 2025
19 checks passed
@github-actions github-actions bot mentioned this pull request Oct 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

regression: #await block does not resolve Promise from +page.server.ts if loader contains another await

2 participants