-
-
Notifications
You must be signed in to change notification settings - Fork 2.1k
breaking: remove Node polyfills (and by extension support for Node 18) #14732
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
🦋 Changeset detectedLatest commit: 47f9561 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
We should probably remove references to Node.js 18 too:
|
good catch, done |
Thanks! Note that we need to update the Vercel adapter major in adapter-auto before we create a new release so that it installs the new major kit/packages/adapter-auto/adapters.js Line 10 in dedda71
|
Vercel supports Node 20 and 22. These versions expose
File
andcrypto
to the global scope, which therefore no longer need to be polyfilled.Marked as a major version because it's technically a breaking change, but not really since you already can't use Node 18 on Vercel.
Please don't delete this checklist! Before submitting the PR, please make sure you do the following:
Tests
pnpm test
and lint the project withpnpm lint
andpnpm check
Changesets
pnpm changeset
and following the prompts. Changesets that add features should beminor
and those that fix bugs should bepatch
. Please prefix changeset messages withfeat:
,fix:
, orchore:
.Edits