Skip to content

Conversation

Rich-Harris
Copy link
Member

@Rich-Harris Rich-Harris commented Oct 7, 2025

We reset input after a successful submission, but that's incorrect — we should only be resetting input when the form is reset, which is the default behaviour after a submission but shouldn't be when you use myform.enhance(...). In that case, the developer is responsible for resetting the form.

In any case, input = {} is incorrect — when the form is reset, we should use the actual values that are present (accounting for defaultValue and <select> initial options and so on). This PR adds a reset handler that fixes it.


Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests

  • Run the tests with pnpm test and lint the project with pnpm lint and pnpm check

Changesets

  • If your PR makes a change that should be noted in one or more packages' changelogs, generate a changeset by running pnpm changeset and following the prompts. Changesets that add features should be minor and those that fix bugs should be patch. Please prefix changeset messages with feat:, fix:, or chore:.

Edits

  • Please ensure that 'Allow edits from maintainers' is checked. PRs without this option may be closed.

Copy link

changeset-bot bot commented Oct 7, 2025

🦋 Changeset detected

Latest commit: d5045d4

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@sveltejs/kit Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@svelte-docs-bot
Copy link

@Rich-Harris Rich-Harris changed the title WIP don't reset form after enhanced form submit fix: don't reset form after enhanced form submit Oct 7, 2025
@Rich-Harris Rich-Harris marked this pull request as ready for review October 7, 2025 14:20
Copy link
Member

@dummdidumm dummdidumm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh this was actually kind of a regression then, because prior to the enhanced remote forms enhance didn't reset

@Rich-Harris Rich-Harris merged commit 0bd9942 into main Oct 7, 2025
22 checks passed
@Rich-Harris Rich-Harris deleted the enhanced-form-inputs-untouched branch October 7, 2025 15:27
@github-actions github-actions bot mentioned this pull request Oct 7, 2025
@vladshcherbin
Copy link

awesome fix 🥳

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants