tweak invalid(...) API
#14625
Merged
tweak invalid(...) API
#14625
+60
−42
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
5 tasks
dummdidumm
approved these changes
Oct 7, 2025
Rich-Harris
added a commit
that referenced
this pull request
Oct 7, 2025
* feat: imperative form validation Not all validation can happen via the schema, this introduces a way to do it imperatively * fix * Apply suggestion from @Rich-Harris Co-authored-by: Rich Harris <richard.a.harris@gmail.com> * Apply suggestion from @Rich-Harris Co-authored-by: Rich Harris <richard.a.harris@gmail.com> * tweak `invalid(...)` API (#14625) * Apply suggestions from code review --------- Co-authored-by: Rich Harris <richard.a.harris@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was playing around with #14624 locally and it's pretty dang cool. But it occurs to me that most of the time, when you use
invalid(...)it will be with a single error, and often it'll be a root-level error. If we optimise for those two facts a slightly different API suggests itself — instead ofinvalid([issue]), we can doinvalid(issue), and instead ofinvalid.$(...)we can just accept strings.So this...
...would become this: