Skip to content

fix: don't exclude remote functions when deploying to Netlify edge functions #14214

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

nickbreaton
Copy link

@nickbreaton nickbreaton commented Aug 14, 2025

Fixes #14216 by making the exludedFiles pattern more restrictive since remote functions are sent at /_app/remote/*. This updated pattern is inline with other adapters like Cloudflare, so I don't anticipate issues:

return [`/${builder.getAppPath()}/immutable/*`, `/${builder.getAppPath()}/version.json`];

I've extended the reproduction repo to use the changes from this PR in:
nickbreaton/svelte-kit-netlify-adapter-repro@main...fix

The permalink for this deploy is available here, which does allow for the remote function to work:
https://689df1462120180008ab45f6--svelte-kit-netlify-adapter-repro.netlify.app/


Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • This message body should clearly illustrate what problems it solves.
  • [-] Ideally, include a test that fails without this PR but passes with it.
    • I've not included this as this seems like to be more a configuration change that would require an E2E with Netlify. Willing to add with some guidance!

Tests

  • Run the tests with pnpm test and lint the project with pnpm lint and pnpm check

Changesets

  • If your PR makes a change that should be noted in one or more packages' changelogs, generate a changeset by running pnpm changeset and following the prompts. Changesets that add features should be minor and those that fix bugs should be patch. Please prefix changeset messages with feat:, fix:, or chore:.

Edits

  • Please ensure that 'Allow edits from maintainers' is checked. PRs without this option may be closed.

Copy link

changeset-bot bot commented Aug 14, 2025

🦋 Changeset detected

Latest commit: eaadd7a

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@sveltejs/adapter-netlify Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

nickbreaton added a commit to nickbreaton/svelte-kit-netlify-adapter-repro that referenced this pull request Aug 14, 2025
nickbreaton added a commit to nickbreaton/svelte-kit-netlify-adapter-repro that referenced this pull request Aug 14, 2025
@nickbreaton nickbreaton changed the title Fix inaccessible remote functions with Netlify edge adapter fix: Fix inaccessible remote functions with Netlify edge adapter Aug 14, 2025
@nickbreaton nickbreaton marked this pull request as ready for review August 14, 2025 14:55
@nickbreaton nickbreaton changed the title fix: Fix inaccessible remote functions with Netlify edge adapter fix: make remote functions accessible when deploying with Netlify edge adapter Aug 14, 2025
@dummdidumm
Copy link
Member

Makes sense, thank you! Could you add a changeset? Then we're good to merge.

@nickbreaton nickbreaton changed the title fix: make remote functions accessible when deploying with Netlify edge adapter fix: remote functions now properly accessible via Netlify edge adapter Aug 15, 2025
@nickbreaton nickbreaton changed the title fix: remote functions now properly accessible via Netlify edge adapter fix: don't exclude remote functions when deploying via Netlify edge functions Aug 15, 2025
@nickbreaton nickbreaton force-pushed the nbreaton/remote-function-netlify-adapater-fix branch 2 times, most recently from 75068df to aacfd6b Compare August 15, 2025 02:25
@nickbreaton nickbreaton changed the title fix: don't exclude remote functions when deploying via Netlify edge functions fix: don't exclude remote functions when deploying to Netlify edge functions Aug 15, 2025
@nickbreaton nickbreaton force-pushed the nbreaton/remote-function-netlify-adapater-fix branch from aacfd6b to 15ee540 Compare August 15, 2025 02:29
@nickbreaton nickbreaton force-pushed the nbreaton/remote-function-netlify-adapater-fix branch from 15ee540 to eaadd7a Compare August 15, 2025 02:38
@nickbreaton
Copy link
Author

Thanks for taking a look @dummdidumm. Apologies for the delay, a changeset has been added.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remote functions: endpoint is inaccessible when deploying via Netlify adapter with edge config
3 participants