-
-
Notifications
You must be signed in to change notification settings - Fork 2.1k
fix: don't exclude remote functions when deploying to Netlify edge functions #14214
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
nickbreaton
wants to merge
2
commits into
sveltejs:main
Choose a base branch
from
nickbreaton:nbreaton/remote-function-netlify-adapater-fix
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
fix: don't exclude remote functions when deploying to Netlify edge functions #14214
nickbreaton
wants to merge
2
commits into
sveltejs:main
from
nickbreaton:nbreaton/remote-function-netlify-adapater-fix
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: eaadd7a The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
nickbreaton
added a commit
to nickbreaton/svelte-kit-netlify-adapter-repro
that referenced
this pull request
Aug 14, 2025
nickbreaton
added a commit
to nickbreaton/svelte-kit-netlify-adapter-repro
that referenced
this pull request
Aug 14, 2025
Makes sense, thank you! Could you add a changeset? Then we're good to merge. |
75068df
to
aacfd6b
Compare
aacfd6b
to
15ee540
Compare
15ee540
to
eaadd7a
Compare
Thanks for taking a look @dummdidumm. Apologies for the delay, a changeset has been added. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #14216 by making the
exludedFiles
pattern more restrictive since remote functions are sent at/_app/remote/*
. This updated pattern is inline with other adapters like Cloudflare, so I don't anticipate issues:kit/packages/adapter-cloudflare/index.js
Line 215 in 233ea22
I've extended the reproduction repo to use the changes from this PR in:
nickbreaton/svelte-kit-netlify-adapter-repro@main...fix
The permalink for this deploy is available here, which does allow for the remote function to work:
https://689df1462120180008ab45f6--svelte-kit-netlify-adapter-repro.netlify.app/
Please don't delete this checklist! Before submitting the PR, please make sure you do the following:
Tests
pnpm test
and lint the project withpnpm lint
andpnpm check
Changesets
pnpm changeset
and following the prompts. Changesets that add features should beminor
and those that fix bugs should bepatch
. Please prefix changeset messages withfeat:
,fix:
, orchore:
.Edits