Skip to content

Conversation

@Rich-Harris
Copy link
Member

@changeset-bot
Copy link

changeset-bot bot commented Aug 7, 2025

⚠️ No Changeset found

Latest commit: 8bcaa8a

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@benmccann
Copy link
Member

Thanks @Rich-Harris! Looks like this is close, but the test failure seems legit:

test-basics@0.0.2-next.0 : test:cross-platform:dev packages\kit\test\apps\basics
  
  > test-basics@0.0.2-next.0 test:cross-platform:dev D:\a\kit\kit\packages\kit\test\apps\basics
  > node test/setup.js && node -e "fs.rmSync('test/errors.json', { force: true })" && DEV=true playwright test test/cross-platform/
  
  'DEV' is not recognized as an internal or external command,
  operable program or batch file.
  D:\a\kit\kit\packages\kit\test\apps\basics:
   ERR_PNPM_RECURSIVE_RUN_FIRST_FAIL  test-basics@0.0.2-next.0 test:cross-platform:dev: `node test/setup.js && node -e "fs.rmSync('test/errors.json', { force: true })" && DEV=true playwright test test/cross-platform/`
  Exit status 1

@Rich-Harris
Copy link
Member Author

what the hell i thought this was literally the whole point of shellEmulator

@Rich-Harris
Copy link
Member Author

emulating windows... more like hellEmulator amirite

@instantiatedwalrus
Copy link

instantiatedwalrus commented Aug 7, 2025

@benmccann
Copy link
Member

Why remove it from pnpm-workspace.yaml? (c0b5120)

I did a code search on GitHub to find examples. rolldown seems to have it there: https://github.com/rolldown/rolldown/blob/b18419e92636fd33c4b3b885ab900f5b239177af/pnpm-workspace.yaml#L14

@benmccann
Copy link
Member

y'all nerd sniped me. I spent way longer on this than intended. It looks like it's mostly working now except for some weird uvu CJS assertion. I sent a separate PR to finish migrating from uvu to vitest: #14145. Hopefully after that's merged we can rebase this PR and everything will be working

@Rich-Harris Rich-Harris merged commit bcc8b42 into main Aug 8, 2025
37 of 38 checks passed
@Rich-Harris Rich-Harris deleted the pnpm-shell-emulator branch August 8, 2025 15:36
@teemingc teemingc mentioned this pull request Aug 12, 2025
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants