Skip to content

feat: add vite-plugin-svelte 6 to the peer dependency range #13921

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jun 25, 2025

Conversation

eltigerchino
Copy link
Member

I forgot to add VPS 6 to the @sveltejs/enhanced-img package's peer dep range. Probably important for users trying out VP6 and rolldown-vite together with the enhanced-img package.


Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests

  • Run the tests with pnpm test and lint the project with pnpm lint and pnpm check

Changesets

  • If your PR makes a change that should be noted in one or more packages' changelogs, generate a changeset by running pnpm changeset and following the prompts. Changesets that add features should be minor and those that fix bugs should be patch. Please prefix changeset messages with feat:, fix:, or chore:.

Edits

  • Please ensure that 'Allow edits from maintainers' is checked. PRs without this option may be closed.

Copy link

changeset-bot bot commented Jun 24, 2025

🦋 Changeset detected

Latest commit: 37dbdb8

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@sveltejs/enhanced-img Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@dominikg
Copy link
Member

the vite plugin svelte name might change soon, so

if (plugin.name === 'vite-plugin-svelte') {
could be a bit brittle. good news is that the new plugin framework is modular so you can use oder: pre or enforce: pre to get in front of the compile plugin without this needing to come in a specific place in the users config

@dominikg
Copy link
Member

just saw that multiple uses exist to detect vite-plugin-svelte by its name, so i'll add one that has that exact name to keep those working

https://github.com/search?q=%2F%5B%27%22%5Dvite-plugin-svelte%5B%27%22%5D%2F&type=code

@eltigerchino eltigerchino merged commit 16bc021 into main Jun 25, 2025
18 checks passed
@eltigerchino eltigerchino deleted the fix-packages branch June 25, 2025 01:11
@github-actions github-actions bot mentioned this pull request Jun 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants