Skip to content

chore: always use manualChunks for bundling single and inline apps #13915

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 23, 2025

Conversation

eltigerchino
Copy link
Member

@eltigerchino eltigerchino commented Jun 23, 2025

Previously, rolldown-vite didn't support manualChunks, so we had to use a workaround. Now that it's implemented in rolldown/rolldown#4311 we can simplify our config options a bit.


Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.
    • we already have a test for checking that single apps have a single bundled JS file

Tests

  • Run the tests with pnpm test and lint the project with pnpm lint and pnpm check

Changesets

  • If your PR makes a change that should be noted in one or more packages' changelogs, generate a changeset by running pnpm changeset and following the prompts. Changesets that add features should be minor and those that fix bugs should be patch. Please prefix changeset messages with feat:, fix:, or chore:.

Edits

  • Please ensure that 'Allow edits from maintainers' is checked. PRs without this option may be closed.

Copy link

changeset-bot bot commented Jun 23, 2025

🦋 Changeset detected

Latest commit: 6868c5c

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@sveltejs/kit Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@eltigerchino eltigerchino changed the title chore: use manualChunks for bundling chore: always use manualChunks for bundling Jun 23, 2025
@eltigerchino eltigerchino changed the title chore: always use manualChunks for bundling chore: always use manualChunks for bundling single and inline apps Jun 23, 2025
@benmccann benmccann merged commit a95d5b8 into main Jun 23, 2025
18 checks passed
@benmccann benmccann deleted the manual-chunks branch June 23, 2025 22:07
@github-actions github-actions bot mentioned this pull request Jun 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants