Skip to content

chore: add tests for treeshaking #13909

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Jun 27, 2025
Merged

chore: add tests for treeshaking #13909

merged 7 commits into from
Jun 27, 2025

Conversation

eltigerchino
Copy link
Member

@eltigerchino eltigerchino commented Jun 20, 2025

related to #13738

This PR adds a test to ensure that the browser and dev conditions from the $app/environment module are treeshaken. This will make the rolldown-vite ecosystem ci fail again since treeshaking isn't on par with Rollup yet rolldown/rolldown#3403

If you want to see the Rolldown output, you can add the rolldown-vite override and run the tests.

    "overrides": {
        "vite": "npm:rolldown-vite@beta"
    }

Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests

  • Run the tests with pnpm test and lint the project with pnpm lint and pnpm check

Changesets

  • If your PR makes a change that should be noted in one or more packages' changelogs, generate a changeset by running pnpm changeset and following the prompts. Changesets that add features should be minor and those that fix bugs should be patch. Please prefix changeset messages with feat:, fix:, or chore:.

Edits

  • Please ensure that 'Allow edits from maintainers' is checked. PRs without this option may be closed.

….svelte

Co-authored-by: Dominik G. <dominik.goepel@gmx.de>
Copy link

changeset-bot bot commented Jun 20, 2025

⚠️ No Changeset found

Latest commit: b46667b

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

eltigerchino and others added 3 commits June 20, 2025 15:27
@eltigerchino eltigerchino requested a review from dominikg June 20, 2025 08:40
),
'utf-8'
);
expect(code).not.toContain('browser');
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

above browser was changed to client, do we have to update this check too?

Copy link
Member Author

@eltigerchino eltigerchino Jun 23, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The checks are actually checking for the browser and dev imports from $app/environment rather than the string itself. Both shouldn't be in the output though if the treeshaking is done correctly. I changed it from "not browser" to "server" because that was causing this assertion to fail.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clarified with a comment - nice work!

@dummdidumm dummdidumm merged commit edec764 into main Jun 27, 2025
18 checks passed
@dummdidumm dummdidumm deleted the treeshaking-tests branch June 27, 2025 08:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants