fix: warning for chrome devtools requests now suggests sv instead of vite plugin #13905

manuel3108 · 2025-06-19T03:00:39Z

Suggest setting up the devtools config using the newly release sv add devtools-json command. Follow-up for #13830
Relates sveltejs/cli#581

Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
This message body should clearly illustrate what problems it solves.
Ideally, include a test that fails without this PR but passes with it.

Tests

Run the tests with pnpm test and lint the project with pnpm lint and pnpm check

Changesets

If your PR makes a change that should be noted in one or more packages' changelogs, generate a changeset by running pnpm changeset and following the prompts. Changesets that add features should be minor and those that fix bugs should be patch. Please prefix changeset messages with feat:, fix:, or chore:.

Edits

Please ensure that 'Allow edits from maintainers' is checked. PRs without this option may be closed.

…vite plugin

changeset-bot · 2025-06-19T03:00:43Z

🦋 Changeset detected

Latest commit: 5b99d16

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package

Name	Type
@sveltejs/kit	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

svelte-docs-bot · 2025-06-19T03:01:04Z

Preview: https://svelte-dev-git-preview-kit-13905-svelte.vercel.app/

manuel3108 · 2025-06-19T03:11:39Z

No clue why this unrelated test is failing, even though I didn't even change code

packages/kit/src/runtime/server/respond.js

Co-authored-by: Ben McCann <322311+benmccann@users.noreply.github.com>

packages/kit/src/runtime/server/respond.js

dominikg · 2025-06-20T07:00:58Z

packages/kit/src/runtime/server/respond.js

 				if (DEV && event.url.pathname === '/.well-known/appspecific/com.chrome.devtools.json') {
 					if (!warned_on_devtools_json_request) {
 						console.warn(
-							`\nGoogle Chrome is requesting ${event.url.pathname} to automatically configure devtools project settings. To serve this file, add this plugin to your Vite config:\n\nhttps://github.com/ChromeDevTools/vite-plugin-devtools-json\n`
+							`\nGoogle Chrome is requesting ${event.url.pathname} to automatically configure devtools project settings. For more details see https://svelte.dev/docs/cli/devtools-json, or to add a plugin to generate and serve this file run:\n\nnpx sv add devtools-json\n`


the message should identify where it was created, right now it sticks out in that it is a plain log without any prefix, finding the cause involves grepping node_modules.

Suggested change

`\nGoogle Chrome is requesting ${event.url.pathname} to automatically configure devtools project settings. For more details see https://svelte.dev/docs/cli/devtools-json, or to add a plugin to generate and serve this file run:\n\nnpx sv add devtools-json\n`

`\n[sveltekit] Google Chrome is requesting ${event.url.pathname} to automatically configure devtools project settings. For more details see https://svelte.dev/docs/cli/devtools-json, or to add a plugin to generate and serve this file run:\n\nnpx sv add devtools-json\n`

this is still advertising to "just add the plugin to resolve this message". What can users do that don't want to use this feature? There's also no mention that this is connected to the chromium workspace folder feature.

It should be clear that adding this enables this feature for everyone accessing a dev-server including that via chromium - in chromium 140 there won't be a way to opt-out of this anymore.

I'd prefer not to add the log prefix. None of SvelteKit's other log messages have a prefix, so it seems really inconsistent. I think the link to svelte.dev docs is a good hint

Agree. No prefix, unless we start adding a prefix to all messages that originate from Kit

@dominikg great points. How about something like this? I think we can mention SvelteKit in the envelope variable name rather than log prefix

Suggested change

`\nGoogle Chrome is requesting ${event.url.pathname} to automatically configure devtools project settings. For more details see https://svelte.dev/docs/cli/devtools-json, or to add a plugin to generate and serve this file run:\n\nnpx sv add devtools-json\n`

`\nA Chromium browser is requesting ${event.url.pathname} to automatically configure devtools project settings. For more details see https://svelte.dev/docs/cli/devtools-json. This message can be disabled by installing the plugin discussed there or by setting SVELTEKIT_IGNORE_DEVTOOLS_REQUESTS=true\n`

Or at the very least make it an option that is selected by default when going through the sv create wizard

Just tried it again to be sure, but that's already the case!

why should that option be enabled by default? this is us opting in to that behavior on the users behalf.

tbh i'd question if that plugin should even be an addon in sv, it is a general DX plugin at best and if these are ok and enabled by default, i think there's a few more we might want to add, starting with vite-plugin-inspect and vite-plugin-qrcode.

Tbf I'd be completely ok with both of those

Maybe inspect is a bit less useful for the general user because you need to kinda understand the build pipeline to use it

The difference is that the absence of the inspect and qrcode plugins doesn't result in a confusing message. Not sure why we keep going over this

Co-authored-by: Rich Harris <hello@rich-harris.dev>

packages/kit/src/runtime/server/respond.js

Co-authored-by: Dominik G. <dominik.goepel@gmx.de>

fix: warning for chrome devtools requests now suggests sv instead of …

d74a196

…vite plugin

benmccann mentioned this pull request Jun 19, 2025

docs: improvements to the devtools-json docs sveltejs/cli#598

Merged

benmccann reviewed Jun 19, 2025

View reviewed changes

packages/kit/src/runtime/server/respond.js Outdated Show resolved Hide resolved

Update packages/kit/src/runtime/server/respond.js

e1abdd6

Co-authored-by: Ben McCann <322311+benmccann@users.noreply.github.com>

dominikg reviewed Jun 20, 2025

View reviewed changes

packages/kit/src/runtime/server/respond.js Outdated Show resolved Hide resolved

dominikg reviewed Jun 20, 2025

View reviewed changes

Update packages/kit/src/runtime/server/respond.js

fb881d5

Co-authored-by: Rich Harris <hello@rich-harris.dev>

dominikg reviewed Jun 20, 2025

View reviewed changes

packages/kit/src/runtime/server/respond.js Outdated Show resolved Hide resolved

Rich-Harris and others added 2 commits June 20, 2025 11:11

Update packages/kit/src/runtime/server/respond.js

67958b0

Co-authored-by: Dominik G. <dominik.goepel@gmx.de>

Update packages/kit/src/runtime/server/respond.js

5b99d16

Co-authored-by: Dominik G. <dominik.goepel@gmx.de>

dummdidumm approved these changes Jun 26, 2025

View reviewed changes

dummdidumm merged commit 1df63bb into sveltejs:main Jun 26, 2025
15 checks passed

github-actions bot mentioned this pull request Jun 26, 2025

Version Packages #13934

Merged

	`\nGoogle Chrome is requesting ${event.url.pathname} to automatically configure devtools project settings. For more details see https://svelte.dev/docs/cli/devtools-json, or to add a plugin to generate and serve this file run:\n\nnpx sv add devtools-json\n`
	`\n[sveltekit] Google Chrome is requesting ${event.url.pathname} to automatically configure devtools project settings. For more details see https://svelte.dev/docs/cli/devtools-json, or to add a plugin to generate and serve this file run:\n\nnpx sv add devtools-json\n`

	`\nGoogle Chrome is requesting ${event.url.pathname} to automatically configure devtools project settings. For more details see https://svelte.dev/docs/cli/devtools-json, or to add a plugin to generate and serve this file run:\n\nnpx sv add devtools-json\n`
	`\nA Chromium browser is requesting ${event.url.pathname} to automatically configure devtools project settings. For more details see https://svelte.dev/docs/cli/devtools-json. This message can be disabled by installing the plugin discussed there or by setting SVELTEKIT_IGNORE_DEVTOOLS_REQUESTS=true\n`

Uh oh!

fix: warning for chrome devtools requests now suggests sv instead of vite plugin #13905

fix: warning for chrome devtools requests now suggests sv instead of vite plugin #13905

Uh oh!

Conversation

manuel3108 commented Jun 19, 2025

Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

Tests

Changesets

Edits

Uh oh!

changeset-bot bot commented Jun 19, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🦋 Changeset detected

Uh oh!

svelte-docs-bot bot commented Jun 19, 2025

Uh oh!

manuel3108 commented Jun 19, 2025

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

dominikg Jun 20, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

changeset-bot bot commented Jun 19, 2025 •

edited

Loading

dominikg Jun 20, 2025 •

edited

Loading