Skip to content

feat: add support for read in edge environments #13859

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/old-moons-lick.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'@sveltejs/adapter-cloudflare': minor
---

feat: add support for `('$app/server').read`
5 changes: 5 additions & 0 deletions .changeset/weak-pillows-doubt.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'@sveltejs/kit': minor
---

feat: export `('@sveltejs/kit/adapter').streamFileContent` for server read implementation in adapter
3 changes: 3 additions & 0 deletions packages/adapter-cloudflare/index.js
Original file line number Diff line number Diff line change
Expand Up @@ -161,6 +161,9 @@ export default function (options = {}) {
return prerender ? emulated.prerender_platform : emulated.platform;
}
};
},
supports: {
read: () => true
}
};
}
Expand Down
5 changes: 4 additions & 1 deletion packages/adapter-cloudflare/src/worker.js
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
import { Server } from 'SERVER';
import { manifest, prerendered, base_path } from 'MANIFEST';
import * as Cache from 'worktop/cfw.cache';
import { streamFileContent } from '@sveltejs/kit/adapter';

const server = new Server(manifest);

Expand All @@ -19,7 +20,9 @@ export default {
async fetch(req, env, context) {
await server.init({
// @ts-expect-error env contains environment variables and bindings
env
env,
read: (file) =>
streamFileContent({ fetch: env.ASSETS.fetch, url: new URL('/' + file, req.url) })
});

// skip cache if "cache-control: no-cache" in request
Expand Down
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
import { read } from '$app/server';
import file from '../../../../../file.txt?url';

export function GET() {
return read(file);
}
11 changes: 11 additions & 0 deletions packages/adapter-cloudflare/test/apps/pages/test/test.js
Original file line number Diff line number Diff line change
@@ -1,6 +1,17 @@
import path from 'node:path';
import { fileURLToPath } from 'node:url';
import fs from 'node:fs/promises';
import { expect, test } from '@playwright/test';

const __dirname = path.dirname(fileURLToPath(import.meta.url));

test('worker works', async ({ page }) => {
await page.goto('/');
await expect(page.locator('h1')).toContainText('Sum: 3');
});

test("('$app/server').read works", async ({ page }) => {
const filecontent = await fs.readFile(path.resolve(__dirname, '../../../file.txt'), 'utf-8');
const response = await page.goto('/read');
expect(await response.text()).toBe(filecontent);
});
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
import { read } from '$app/server';
import file from '../../../../../file.txt?url';

export function GET() {
return read(file);
}
11 changes: 11 additions & 0 deletions packages/adapter-cloudflare/test/apps/workers/test/test.js
Original file line number Diff line number Diff line change
@@ -1,6 +1,17 @@
import path from 'node:path';
import { fileURLToPath } from 'node:url';
import fs from 'node:fs/promises';
import { expect, test } from '@playwright/test';

const __dirname = path.dirname(fileURLToPath(import.meta.url));

test('worker works', async ({ page }) => {
await page.goto('/');
await expect(page.locator('h1')).toContainText('Sum: 3');
});

test("('$app/server').read works", async ({ page }) => {
const filecontent = await fs.readFile(path.resolve(__dirname, '../../../file.txt'), 'utf-8');
const response = await page.goto('/read');
expect(await response.text()).toBe(filecontent);
});
1 change: 1 addition & 0 deletions packages/adapter-cloudflare/test/file.txt
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Hello! This file is read by `('$app/server').read`.
4 changes: 4 additions & 0 deletions packages/kit/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -83,6 +83,10 @@
"types": "./types/index.d.ts",
"import": "./src/exports/index.js"
},
"./adapter": {
"types": "./types/index.d.ts",
"import": "./src/exports/adapter/index.js"
},
"./node": {
"types": "./types/index.d.ts",
"import": "./src/exports/node/index.js"
Expand Down
1 change: 1 addition & 0 deletions packages/kit/scripts/generate-dts.js
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@ await createBundle({
output: 'types/index.d.ts',
modules: {
'@sveltejs/kit': 'src/exports/public.d.ts',
'@sveltejs/kit/adapter': 'src/exports/adapter/index.js',
'@sveltejs/kit/hooks': 'src/exports/hooks/index.js',
'@sveltejs/kit/node': 'src/exports/node/index.js',
'@sveltejs/kit/node/polyfills': 'src/exports/node/polyfills.js',
Expand Down
44 changes: 44 additions & 0 deletions packages/kit/src/exports/adapter/index.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,44 @@
/**
* @typedef StreamFileContentOptions
* @property {typeof fetch} fetch The fetch function to use for fetching the asset.
* @property {string | URL} url The URL of the asset to fetch.
* @property {AbortController} [controller] An optional AbortController to cancel the fetch operation.
*/

/**
* synchronously returns a ReadableStream containing the body of an asynchronously fetched asset
* original use case: adapters' server read implementation
* @param {StreamFileContentOptions } options
* @returns {ReadableStream}
*/
export function streamFileContent(options) {
const { fetch, url, controller: abortController = new AbortController() } = options;

return new ReadableStream({
async start(controller) {
try {
const response = await fetch(new URL(url), { signal: abortController.signal });
if (!response.ok) {
throw new Error(`Failed to fetch (${response.status} - ${response.statusText})`);
}
if (!response.body) {
controller.close();
return;
}
const reader = response.body.getReader();
while (true) {
const { done, value } = await reader.read();
if (done) break;
controller.enqueue(value);
}

controller.close();
} catch (error) {
controller.error(error);
}
},
cancel(reason) {
abortController.abort(reason);
}
});
}
75 changes: 75 additions & 0 deletions packages/kit/src/exports/adapter/index.spec.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,75 @@
import { test, expect, vi } from 'vitest';
import { streamFileContent } from './index.js';

const mockedFetch = vi.fn(fetch);

test('stream successfully', async () => {
const content = 'Hello, world!';
mockedFetch.mockReturnValueOnce(
new Promise((resolve) =>
resolve(new Response(content, { status: 200, headers: { 'Content-Type': 'text/plain' } }))
)
);
const stream = streamFileContent({
fetch: mockedFetch,
url: 'http://assets.local/file.txt'
});
expect(await new Response(stream).text()).toBe(content);
});

test('stream with 404', async () => {
mockedFetch.mockReturnValueOnce(
new Promise((resolve) => resolve(new Response(null, { status: 404, statusText: 'Not Found' })))
);
const stream = streamFileContent({
fetch: mockedFetch,
url: 'http://assets.local/missing.txt'
});
await expect(new Response(stream).text()).rejects.toThrow('404 - Not Found');
});

test('stream with null body', async () => {
mockedFetch.mockReturnValueOnce(
new Promise((resolve) => resolve(new Response(null, { status: 204, statusText: 'No Content' })))
);
const stream = streamFileContent({
fetch: mockedFetch,
url: 'http://assets.local/empty.txt'
});
expect(await new Response(stream).text()).toBe('');
});

test('stream with invalid URL', async () => {
const stream = streamFileContent({
fetch: mockedFetch,
url: '/assets.local/invalid.txt'
});
await expect(new Response(stream).text()).rejects.toThrow('Invalid URL');
});

test('stream with aborted fetch', async () => {
const controller = new AbortController();
// abort with DOMException otherwise will fail in CI
// see https://github.com/nodejs/node/issues/49557
controller.abort(new DOMException('Timeout'));
const stream = streamFileContent({
fetch: mockedFetch,
url: 'http://assets.local/abort.txt',
controller
});
await expect(new Response(stream).text()).rejects.toThrow('Timeout');
});

test('cancelled stream should trigger abort signal', async () => {
const controller = new AbortController();
mockedFetch.mockReturnValueOnce(new Promise(() => {}));
const stream = streamFileContent({
fetch: mockedFetch,
url: 'http://assets.local/cancel.txt',
controller
});
const abortListener = vi.fn();
controller.signal.addEventListener('abort', abortListener);
await stream.cancel('User cancelled');
expect(abortListener).toHaveBeenCalled();
});
24 changes: 24 additions & 0 deletions packages/kit/types/index.d.ts
Original file line number Diff line number Diff line change
Expand Up @@ -2056,6 +2056,30 @@ declare module '@sveltejs/kit' {
export {};
}

declare module '@sveltejs/kit/adapter' {
/**
* synchronously returns a ReadableStream containing the body of an asynchronously fetched asset
* original use case: adapters' server read implementation
* */
export function streamFileContent(options: StreamFileContentOptions): ReadableStream;
export type StreamFileContentOptions = {
/**
* The fetch function to use for fetching the asset.
*/
fetch: typeof fetch;
/**
* The URL of the asset to fetch.
*/
url: string | URL;
/**
* An optional AbortController to cancel the fetch operation.
*/
controller?: AbortController | undefined;
};

export {};
}

declare module '@sveltejs/kit/hooks' {
/**
* A helper function for sequencing multiple `handle` calls in a middleware-like manner.
Expand Down
Loading