Skip to content

fix: build failure using adapter-cloudflare with paths.base (#13769) #13846

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 3, 2025

Conversation

amodm
Copy link
Contributor

@amodm amodm commented May 31, 2025

This PR fixes #13769 by ensuring that assets_dir exists before the 404.html is potentially generated.

For details of the issue, please see #13769, but a one line summary is: vite build fails when using @sveltejs/adapter-cloudflare along with a paths.base in svelte.config.js.


Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests

  • Run the tests with pnpm test and lint the project with pnpm lint and pnpm check

Changesets

  • If your PR makes a change that should be noted in one or more packages' changelogs, generate a changeset by running pnpm changeset and following the prompts. Changesets that add features should be minor and those that fix bugs should be patch. Please prefix changeset messages with feat:, fix:, or chore:.

Edits

  • Please ensure that 'Allow edits from maintainers' is checked. PRs without this option may be closed.

Copy link

changeset-bot bot commented May 31, 2025

🦋 Changeset detected

Latest commit: fe7290d

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@sveltejs/adapter-cloudflare Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@amodm
Copy link
Contributor Author

amodm commented May 31, 2025

The test failure seems unrelated to the changes in this PR. Here's the same test on a different machine:

Running 858 tests using 2 workers
··············{ requests: [] }
··································································
················································································
················°·······························································
··················°°°°°°°°°°°°°°°°°°°·°°°°°°°°°°°°°°°°°°°°°°°°°°°°°°°°°°°°°°····
········································································°·······
·····························°°°°°°°°°°°°°°°°°°°°°°°°°°°°°°°°°°°°°°°°°°°°°°°°°°°
°°°°°°°°°°°°°°°°°°°°°°°°°°°°°°°°°°°°°°°°°°°°°°°°°°°°°°°°°°°°°°°°°°°°°°°°°°°°°°°°
°°°°°°°°°°°°°°°°°°°°°°°°°°°°°°°°°°°°°°°°°°°°°·°·································
················································································
··············································································°·
·····················°···············°····················
  239 skipped
  619 passed (1.3m)

> test-options@0.0.1 test:server-side-route-resolution:build **redacted**/kit/packages/kit/test/apps/options
> node -e "fs.rmSync('test/errors.json', { force: true })" && cross-env ROUTER_RESOLUTION=server playwright test


Running 52 tests using 2 workers
····················································
  52 passed (7.8s)

@elliott-with-the-longest-name-on-github elliott-with-the-longest-name-on-github merged commit f4d7643 into sveltejs:main Jun 3, 2025
13 of 15 checks passed
@github-actions github-actions bot mentioned this pull request Jun 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Build fails with adapter-cloudflare when config.kit.paths.base is used
3 participants