Skip to content

fix: set $env and $app/environment variables before analysing server nodes #13790

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
May 18, 2025

Conversation

eltigerchino
Copy link
Member

@eltigerchino eltigerchino commented May 15, 2025

fixes #13785

This PR ensures the $env and $app/environment, etc. are set before we evaluate the +page.server/+layout.server files so that they have the correct values when we are analysing the page options of each node. It now also uses the static analysis cache when we build the server nodes again. This lets us avoid evaluating the server files again where those internal variables aren't set.


Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests

  • Run the tests with pnpm test and lint the project with pnpm lint and pnpm check

Changesets

  • If your PR makes a change that should be noted in one or more packages' changelogs, generate a changeset by running pnpm changeset and following the prompts. Changesets that add features should be minor and those that fix bugs should be patch. Please prefix changeset messages with feat:, fix:, or chore:.

Edits

  • Please ensure that 'Allow edits from maintainers' is checked. PRs without this option may be closed.

Copy link

changeset-bot bot commented May 15, 2025

🦋 Changeset detected

Latest commit: 9c5eb11

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@sveltejs/kit Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@Rich-Harris Rich-Harris merged commit df163d2 into main May 18, 2025
18 checks passed
@Rich-Harris Rich-Harris deleted the fix-server-node-analysis branch May 18, 2025 16:42
This was referenced May 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

import { building } from '$app/environment' is false while building
2 participants