-
-
Notifications
You must be signed in to change notification settings - Fork 2.1k
docs: clarify what handleFetch
affects
#13788
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
🦋 Changeset detectedLatest commit: cb2bded The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
handleFetch
affects
@@ -126,7 +126,7 @@ export async function handleFetch({ request, fetch }) { | |||
} | |||
``` | |||
|
|||
**Credentials** | |||
#### Credentials |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's revert it for now, a h4 is rendered super tiny on svelte.dev (maybe we should adjust that over there; not sure)
#### Credentials | |
**Credentials** |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Neither makes sense — we deliberately don't use bolding anywhere, and avoid deeply nested heading hierarchies. I think we should just reword it (it doesn't really need to be a subsection). Will push something
This PR includes some additional server functions that
handleFetch
affects that are left out in the current description. Technically it also affects theevent.fetch
inhandleFetch
itself, but I'm wondering why that's a thing in the first place since it would make it recursive 😅Please don't delete this checklist! Before submitting the PR, please make sure you do the following:
Tests
pnpm test
and lint the project withpnpm lint
andpnpm check
Changesets
pnpm changeset
and following the prompts. Changesets that add features should beminor
and those that fix bugs should bepatch
. Please prefix changeset messages withfeat:
,fix:
, orchore:
.Edits