Skip to content

docs: clarify what handleFetch affects #13788

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
May 18, 2025
Merged

docs: clarify what handleFetch affects #13788

merged 5 commits into from
May 18, 2025

Conversation

eltigerchino
Copy link
Member

@eltigerchino eltigerchino commented May 14, 2025

This PR includes some additional server functions that handleFetch affects that are left out in the current description. Technically it also affects the event.fetch in handleFetch itself, but I'm wondering why that's a thing in the first place since it would make it recursive 😅


Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests

  • Run the tests with pnpm test and lint the project with pnpm lint and pnpm check

Changesets

  • If your PR makes a change that should be noted in one or more packages' changelogs, generate a changeset by running pnpm changeset and following the prompts. Changesets that add features should be minor and those that fix bugs should be patch. Please prefix changeset messages with feat:, fix:, or chore:.

Edits

  • Please ensure that 'Allow edits from maintainers' is checked. PRs without this option may be closed.

@eltigerchino eltigerchino added the documentation Improvements or additions to documentation label May 14, 2025
Copy link

changeset-bot bot commented May 14, 2025

🦋 Changeset detected

Latest commit: cb2bded

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@sveltejs/kit Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@svelte-docs-bot
Copy link

@eltigerchino eltigerchino changed the title docs: clarify what handleFetch affects docs: clarify what handleFetch affects May 14, 2025
@@ -126,7 +126,7 @@ export async function handleFetch({ request, fetch }) {
}
```

**Credentials**
#### Credentials
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's revert it for now, a h4 is rendered super tiny on svelte.dev (maybe we should adjust that over there; not sure)

Suggested change
#### Credentials
**Credentials**

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Neither makes sense — we deliberately don't use bolding anywhere, and avoid deeply nested heading hierarchies. I think we should just reword it (it doesn't really need to be a subsection). Will push something

@Rich-Harris Rich-Harris merged commit 5ab5762 into main May 18, 2025
18 checks passed
@Rich-Harris Rich-Harris deleted the docs-handleFetch branch May 18, 2025 17:11
This was referenced May 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants