-
-
Notifications
You must be signed in to change notification settings - Fork 2.1k
feat: server side route resolution #13379
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
75 commits
Select commit
Hold shift + click to select a range
388363b
first draft of server routing manifest
dummdidumm 70d1a8f
_app/routes/... endpoint
dummdidumm b0ecbeb
WIP client integration
dummdidumm 72782d8
do this via ssrmanifest instead (previous approach does not work beca…
dummdidumm a107444
add option
dummdidumm 63808a9
integrate option
dummdidumm e8528f5
oops
dummdidumm e14b473
silence vite warning
dummdidumm f65ceb3
obsolete
dummdidumm 0bc5cd8
oops
dummdidumm 3be38e4
fix
dummdidumm b05f960
see what happens if everything runs with server routing
dummdidumm 5fd674f
fixes
dummdidumm 56f7b71
temporarily adjust test
dummdidumm 678cd28
adjust tests
dummdidumm 98f10eb
fix
dummdidumm 3e7211b
disallow adapter-static with resolution=server
dummdidumm 733445d
adjust order of token updates; they need to happen before the first a…
dummdidumm 8e53116
fix
dummdidumm bd29ba5
oops
dummdidumm b0653e0
prerender route resolution requests
dummdidumm a082fc2
create client routes for server as part of manifest already. This sav…
dummdidumm ef74189
run all of apps/basics in a separate github action with router.resol…
dummdidumm 46507b1
lint
dummdidumm 21cf0ce
feedback
dummdidumm 1af6c1a
oops
dummdidumm fe0f25f
make server routing base path aware
dummdidumm 38b14eb
here instead
dummdidumm 7288023
simplify
dummdidumm 453aa2a
make imports relative
dummdidumm 5bced02
fix
dummdidumm 42df818
lint
dummdidumm 89aa78b
run options test suite in server routing mode, too
dummdidumm c6941e4
fix
dummdidumm 24b8cd6
fix artifact upload
dummdidumm ec8b7fa
vercel adapter (hope this works)
dummdidumm 7c2a23e
fix
dummdidumm f38a6d2
generate symlink before running server routing tests
dummdidumm 24ff293
take base path into account
dummdidumm df5efb4
remove unnecessary validation, make sure route resolution is also sav…
dummdidumm 8ffb62d
harmonize pathname endings before sending to resolution endpoint
dummdidumm c99a78b
take assets path into account when creating import paths during serve…
dummdidumm 1528dfa
obsolete
dummdidumm 2f53412
nomenclature
dummdidumm 9e408f6
changeset
dummdidumm 1bb22a1
Apply suggestions from code review
dummdidumm 0337eed
don't include root error/layout if no routes
dummdidumm b458c81
regenerate types
dummdidumm 7cf48b2
prettier
dummdidumm 6a0ab67
Apply suggestions from code review
dummdidumm 0342bb7
type generation
elliott-with-the-longest-name-on-github cfe0477
omit base path from route resolution endpoint
dummdidumm c9734fb
tidier output
dummdidumm 5521417
make server route / route in hydrate clearer
dummdidumm 56bd377
comment
dummdidumm d8362a7
Merge remote-tracking branch 'origin/main' into server-side-routing
dummdidumm ccb0f67
exclude default options from route resolution function
Rich-Harris 88db9e6
Merge branch 'server-side-routing' of github.com:sveltejs/kit into se…
Rich-Harris a520b30
'routes' -> 'route', more consistent with endpoint naming conventions…
Rich-Harris 6964355
use same naming convention as verb_data_suffix — prevents the need fo…
Rich-Harris bf3676a
make add_resolution_prefix operate on strings, tweak implementation
Rich-Harris 6e74c74
simplify function signatures by making app_dir globally available
Rich-Harris 3383fae
remove now-unused options.app_dir
Rich-Harris 9cc37b4
pass pathname into resolution helpers, for parity with similar __data…
Rich-Harris c03c47a
move pathname manipulation functions into their own module
Rich-Harris 4ce9070
move more stuff into pathname.js, DRY out
Rich-Harris 24b6d13
simplify
Rich-Harris 3f366cf
assets is always absolute, config validation will fail otherwise
Rich-Harris cec8994
lint
Rich-Harris 3181914
unused
Rich-Harris b0bfc3c
lint
Rich-Harris b88fc3a
stricter interface
Rich-Harris b9156e7
use generate terminology in line with generate_manifest, which is a s…
Rich-Harris 8b36c85
cosmetic change, to make route modules more readable
Rich-Harris 27a8243
save a few bytes
Rich-Harris File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,5 @@ | ||
--- | ||
'@sveltejs/adapter-vercel': minor | ||
--- | ||
|
||
feat: generate edge function dedicated to server side route resolution when using that option in SvelteKit |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,5 @@ | ||
--- | ||
'@sveltejs/kit': minor | ||
--- | ||
|
||
feat: support server-side route resolution |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.