Skip to content

fix: catch error when resolving peer dep #13334

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 17, 2025
Merged

fix: catch error when resolving peer dep #13334

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
42b0753
catch error when resolving dep
eltigerchino Jan 17, 2025
b2c6c8f
Update packages/kit/src/utils/import.js
dummdidumm Jan 17, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 9 additions & 4 deletions packages/kit/src/utils/import.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,10 +11,15 @@ export async function resolve_peer_dependency(dependency) {
try {
// @ts-expect-error the types are wrong
const resolved = imr.resolve(dependency, pathToFileURL(process.cwd() + '/dummy.js'));
return await import(resolved).catch(() => import(dependency));
return await import(resolved);
} catch {
throw new Error(
`Could not resolve peer dependency "${dependency}" relative to your project — please install it and try again.`
);
try {
// both imr.resolve and await import above can throw, which is why we can't just do import(resolved).catch(...) above
return await import(dependency);
} catch {
throw new Error(
`Could not resolve peer dependency "${dependency}" relative to your project — please install it and try again.`
);
}
}
}
Loading