fix: prefix node builtins for bundled files

[eltigerchino]

Adds a rollup plugin to prefix all builtin node imports (including transitive dependencies). ChatGPT helped with this one so I'm sure it can be improved. Additionally, for some reason, it makes the build faster by a few ms (I thought an additional plugin would make it slower).

This solves the issue of current and potentially future transitive imports from not having the node: prefix.

Before:

After:

---

Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

• It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
• This message body should clearly illustrate what problems it solves.
• Ideally, include a test that fails without this PR but passes with it.

Tests

• Run the tests with pnpm test and lint the project with pnpm lint and pnpm check

Changesets

• If your PR makes a change that should be noted in one or more packages' changelogs, generate a changeset by running pnpm changeset and following the prompts. Changesets that add features should be minor and those that fix bugs should be patch. Please prefix changeset messages with feat:, fix:, or chore:.

Edits

• Please ensure that 'Allow edits from maintainers' is checked. PRs without this option may be closed.

[changeset-bot]

🦋 Changeset detected

Latest commit: e67b38a

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package

Name	Type
@sveltejs/adapter-node	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

[Conduitry]

I feel like we ought to be able to do this with the resolveId hook and then marking that rewritten module name as external. Have you already tried this? Hacking at the final string feels quite brittle.

[eltigerchino]

Yeah I've tried resolveId but that didn't work for the transitive imports. I wasn't sure if there was another way. Thinking about it we should probably close this since it's so risky with the current regex

[eltigerchino]

I've updated the regex to match on import declarations (from '...') to be less brittle (but brittle nevertheless).

[benmccann]

Hmm. I don't know. Personally I'm not a fan of complicating our build process in this way. I think it's better to ensure that polka and sirv include node: from the beginning. Maybe there's a test that can be added in their test suites or something along those lines. Or maybe it could be a feature in @rollup/plugin-node-resolve?

[eltigerchino]

I think I'll close this. It's unlikely we'll be adding new dependencies and it might be better practice to update the deps with the non-node prefixes.

https://github.com/lukeed/sirv/blob/50b1964b8a8342e14a711d47f793298c2a7aeeb7/packages/sirv/index.js#L1-L3

https://github.com/lukeed/totalist/blob/4b071d3e54d466a4059de89006c752da782c8b02/src/sync.js#L1-L2