Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: correctly match asset filenames if base path is set #12075

Merged
merged 3 commits into from
Jul 23, 2024

Conversation

eltigerchino
Copy link
Member

fixes #12060

Exports the base path of the project so we can remove the base path from the request URL pathname when matching against the static asset filenames in the manifest that are saved without the base path.

might add some tests later just because the path matching has proven to be error prone


Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests

  • Run the tests with pnpm test and lint the project with pnpm lint and pnpm check

Changesets

  • If your PR makes a change that should be noted in one or more packages' changelogs, generate a changeset by running pnpm changeset and following the prompts. Changesets that add features should be minor and those that fix bugs should be patch. Please prefix changeset messages with feat:, fix:, or chore:.

Edits

  • Please ensure that 'Allow edits from maintainers' is checked. PRs without this option may be closed.

Copy link

changeset-bot bot commented Apr 3, 2024

🦋 Changeset detected

Latest commit: 38fcb8f

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
@sveltejs/adapter-cloudflare-workers Patch
@sveltejs/adapter-cloudflare Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Member

@benmccann benmccann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sorry it took me awhile to get to this one

@benmccann benmccann merged commit c1249f5 into main Jul 23, 2024
13 checks passed
@benmccann benmccann deleted the fix-cloudflare-static-assets-base branch July 23, 2024 14:35
@github-actions github-actions bot mentioned this pull request Jul 23, 2024
@eltigerchino
Copy link
Member Author

sorry it took me awhile to get to this one

No worries! I actually forgot about this one. I think it's a pretty small edge case since cloudflare pages doesn't officially support setting a base path for projects(?)

paoloricciuti pushed a commit to paoloricciuti/kit that referenced this pull request Jul 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Static assets are not served if base path is set
2 participants