adapter-vercel seems to be broken at @sveltejs/kit@1.0.0-next.292 #4224

brunobely · 2022-03-05T00:50:53Z

Describe the bug

Vercel builds seem to be broken by #4192 since adapter-vercel still uses builder.prerender.

Reproduction

Run npm run build to see error.

Logs

At the end of build...

> Using @sveltejs/adapter-vercel
> builder.prerender() has been removed. Prerendering now takes place in the build phase — see builder.prerender and builder.writePrerendered
    at Object.prerender (file:///home/projects/sveltejs-kit-template-default-ansvrj/node_modules/@sveltejs/kit/dist/chunks/index4.js:183:10)
    at adapt (file:///home/projects/sveltejs-kit-template-default-ansvrj/node_modules/@sveltejs/adapter-vercel/index.js:116:38)
    at adapt (file:///home/projects/sveltejs-kit-template-default-ansvrj/node_modules/@sveltejs/kit/dist/chunks/index4.js:202:8)
    at eval (file:///home/projects/sveltejs-kit-template-default-ansvrj/node_modules/@sveltejs/kit/dist/cli.js:956:11)

System Info

Default node.new/sveltekit env. Left the command above running for ~5min and got no response.

Severity

blocking an upgrade

Additional Information

Blocks upgrade to @sveltejs/kit@1.0.0-next.292

The text was updated successfully, but these errors were encountered:

Conduitry · 2022-03-05T01:46:29Z

It looks like #4192 didn't include the appropriate changesets for any of the adapters, and so they weren't actually released.

Travja · 2022-03-05T05:35:40Z

Just going to note that this appears to impact more than just vercel. I'm attempting to build with the static-adapter and running into the same error message.

evdama · 2022-03-05T09:04:02Z

yes, same for adapter-node

Using @sveltejs/adapter-node
> builder.prerender() has been removed. Prerendering now takes place in the build phase — see builder.prerender and builder.writePrerendered
    at Object.prerender (file:///Users/sa/0/svk/node_modules/.pnpm/@sveltejs+kit@1.0.0-next.292_svelte@3.46.4/node_modules/@sveltejs/kit/dist/chunks/index4.js:172:10)
    at adapt (file:///Users/sa/0/svk/node_modules/.pnpm/@sveltejs+adapter-node@1.0.0-next.70/node_modules/@sveltejs/adapter-node/index.js:39:18)
    at adapt (file:///Users/sa/0/svk/node_modules/.pnpm/@sveltejs+kit@1.0.0-next.292_svelte@3.46.4/node_modules/@sveltejs/kit/dist/chunks/index4.js:191:8)
    at file:///Users/sa/0/svk/node_modules/.pnpm/@sveltejs+kit@1.0.0-next.292_svelte@3.46.4/node_modules/@sveltejs/kit/dist/cli.js:936:11
 ELIFECYCLE  Command failed with exit code 1.
node:internal/modules/cjs/loader:936
  throw err;
  ^

Error: Cannot find module '/Users/sa/0/svk/build/index.js'
    at Function.Module._resolveFilename (node:internal/modules/cjs/loader:933:15)
    at Function.Module._load (node:internal/modules/cjs/loader:778:27)
    at Function.executeUserEntryPoint [as runMain] (node:internal/modules/run_main:77:12)
    at node:internal/main/run_main_module:17:47 {
  code: 'MODULE_NOT_FOUND',
  requireStack: []
}

Node.js v17.6.0
m1-mini:svk sa$ svelte-kit --version
svelte-kit, 1.0.0-next.292
m1-mini:svk sa$

faisalramdan17 · 2022-03-05T10:48:11Z

The solution from me turns back or use the previous version that 1.0.0-next.288 or 1.0.0-next.291 .
you can try :

Change "@sveltejs/kit": "next", to be "@sveltejs/kit": "1.0.0-next.291", at package.json.
Remove "prepare": "svelte-kit sync" at package.json (if any there).
Run npm install
After that commit & push your repo
Enjoy guys!

Thanks

Sunyuzu · 2022-03-05T12:24:10Z

@sveltejs/kit@1.0.0-next.291 is also okay. Hope to fix
Thank you @faisalramdan17 for information.

HalCodes · 2022-03-05T12:58:15Z

Confirmed that this issue also affects @sveltejs/adapter-netlify. Rolling back to @sveltejs/kit@1.0.0-next.291 is a working workaround.

nstuyvesant · 2022-03-05T16:52:44Z

See this issue is closed but I'm still experiencing the problem with adapter-node. Just reverted to SvelteKit 1.0.0-next.291 as a temporary fix.

frederikhors · 2022-03-05T17:01:38Z

The build is broken. The release of adapter-static 29 is coming.

K-Sato1995 · 2022-03-06T00:32:23Z

The solution from me turns back or use the previous version that 1.0.0-next.288.
@sveltejs/kit@1.0.0-next.291

so any version that doesn't include the changes made by #4192 currently works?

baseballyama · 2022-03-06T02:30:49Z

so any version that doesn't include the changes made by #4192 currently works?

Now we can install @sveltejs/adapter-static@1.0.0-next.29 and other latest adapters!

See: sveltejs/kit#4224 (comment)

phiberber · 2022-03-16T15:13:09Z

so any version that doesn't include the changes made by #4192 currently works?

Now we can install @sveltejs/adapter-static@1.0.0-next.29 and other latest adapters!

I'm still having the same issue even with adapter-static 1.0.0-next.29.

amarhasic · 2022-03-18T13:11:49Z

Same here, issue persists even with rolling back the adapter version.

benmccann · 2022-03-18T13:47:14Z

It would be much more useful to open a new issue rather than comment on a closed issue. The comments here have none of the information that would be required to debug an issue and the issue template will guide you to providing that information

saturnonearth · 2022-03-18T14:36:20Z

Same here, issue persists even with rolling back the adapter version.

I managed to fix mine by manually installing/updating both sveltekit and the adapter even though they were set to install the latest version when building in Netlify.

benmccann · 2022-03-18T15:28:48Z

You probably needed to update your npm lock file

johnkegd · 2022-04-02T11:45:22Z

Thanks dude. @faisalramdan17

mhenrichsen · 2022-04-22T13:08:08Z

After much trial and error here are some settings that work:

"@sveltejs/adapter-netlify": "1.0.0-next.49",
"@sveltejs/kit": "1.0.0-next.291",

nmsobri · 2022-04-25T06:07:38Z

why is this closed? has it being fixed?

baseballyama · 2022-04-25T07:14:23Z

Sometimes destructive change occur because kit is under beta.
And adapters may be updated at the same time accordingly.
This means that the kit and adapters is only work with certain version combinations.
So when you update kit version, I recommend that adapter version also should update as well.

This problem was opened when release timing between kit and adapters was off by several hours.
And it was fixed few hours later and this issue is now closed.

If you have a problem now, you need to open a new issue.

justingolden21 · 2022-05-06T06:57:30Z

Has this issue been fixed? What version of the netlify adapter is necessary to fix?

Had no idea why my code was failing until this thread, and I didn't even update or install or remove any packages...

EDIT: ran npm update and now on build I get builder.writePrerendered is not a function

lukas-h · 2022-05-06T16:41:46Z

Ran into the same problem yesterday with adapter-node and had to downgrade to 288.

qudo-code · 2022-05-06T20:37:02Z

Ran into the same problem yesterday with adapter-node and had to downgrade to 288.

Yeah, for me I only got around it with some magical combination of downgraded versions. Eventually something worked, not ideal by any means. 🤷

tallestlegacy · 2022-06-02T14:20:35Z

I did a pnpm update and it just worked
good things do happen when you update after all

Also, update adapter-static to 1.0.0-next.29, following the instructions from sveltejs/kit#4224 (comment) and setting kit.prerender.default to true (whatever that means...)

Conduitry added the bug Something isn't working label Mar 5, 2022

Antonio-Bennett mentioned this issue Mar 5, 2022

Vercel Deployment failing at the moment Antonio-Bennett/personal-website#4

Closed

baseballyama mentioned this issue Mar 5, 2022

[chore] add missing changeset #4229

Merged

5 tasks

benmccann closed this as completed in #4229 Mar 5, 2022

PH4NTOMiki mentioned this issue Mar 5, 2022

From 1.0.0-next.292: adapter-static: builder.prerender() has been removed. Prerendering now takes place in the build phase — see builder.prerender and builder.writePrerendered #4237

Closed

necmettin mentioned this issue Mar 6, 2022

builder.writePrerendered is not a function #4259

Closed

nachtjasmin added a commit to nachtjasmin/corona-noergel-app that referenced this issue Mar 9, 2022

build: adjust for SvelteKit changes

825b0d1

See: sveltejs/kit#4224 (comment)

dependabot bot pushed a commit to nachtjasmin/corona-noergel-app that referenced this issue Mar 9, 2022

build: adjust for SvelteKit changes

e7ef85b

See: sveltejs/kit#4224 (comment)

incontrolapps added a commit to ONSvisual/scrolly_AML_robo_animation_svelteKit that referenced this issue Mar 28, 2022

did this sveltejs/kit#4224 (comment)

31cf7c1

alexander-mart mentioned this issue May 7, 2022

builder.prerender() has been removed. Prerendering now takes place in the build phase — see builder.prerender and builder.writePrerendered antony/sveltekit-adapter-browser-extension#11

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

adapter-vercel seems to be broken at @sveltejs/kit@1.0.0-next.292 #4224

adapter-vercel seems to be broken at @sveltejs/kit@1.0.0-next.292 #4224

brunobely commented Mar 5, 2022

Conduitry commented Mar 5, 2022

Travja commented Mar 5, 2022

evdama commented Mar 5, 2022 •

edited

Loading

faisalramdan17 commented Mar 5, 2022 •

edited

Loading

Sunyuzu commented Mar 5, 2022 •

edited

Loading

HalCodes commented Mar 5, 2022

nstuyvesant commented Mar 5, 2022

frederikhors commented Mar 5, 2022

K-Sato1995 commented Mar 6, 2022 •

edited

Loading

baseballyama commented Mar 6, 2022

phiberber commented Mar 16, 2022

amarhasic commented Mar 18, 2022

benmccann commented Mar 18, 2022

saturnonearth commented Mar 18, 2022

benmccann commented Mar 18, 2022

johnkegd commented Apr 2, 2022

mhenrichsen commented Apr 22, 2022

nmsobri commented Apr 25, 2022

baseballyama commented Apr 25, 2022

justingolden21 commented May 6, 2022 •

edited

Loading

lukas-h commented May 6, 2022

qudo-code commented May 6, 2022

tallestlegacy commented Jun 2, 2022

adapter-vercel seems to be broken at @sveltejs/kit@1.0.0-next.292 #4224

adapter-vercel seems to be broken at @sveltejs/kit@1.0.0-next.292 #4224

Comments

brunobely commented Mar 5, 2022

Describe the bug

Reproduction

Logs

System Info

Severity

Additional Information

Conduitry commented Mar 5, 2022

Travja commented Mar 5, 2022

evdama commented Mar 5, 2022 • edited Loading

faisalramdan17 commented Mar 5, 2022 • edited Loading

Sunyuzu commented Mar 5, 2022 • edited Loading

HalCodes commented Mar 5, 2022

nstuyvesant commented Mar 5, 2022

frederikhors commented Mar 5, 2022

K-Sato1995 commented Mar 6, 2022 • edited Loading

baseballyama commented Mar 6, 2022

phiberber commented Mar 16, 2022

amarhasic commented Mar 18, 2022

benmccann commented Mar 18, 2022

saturnonearth commented Mar 18, 2022

benmccann commented Mar 18, 2022

johnkegd commented Apr 2, 2022

mhenrichsen commented Apr 22, 2022

nmsobri commented Apr 25, 2022

baseballyama commented Apr 25, 2022

justingolden21 commented May 6, 2022 • edited Loading

lukas-h commented May 6, 2022

qudo-code commented May 6, 2022

tallestlegacy commented Jun 2, 2022

evdama commented Mar 5, 2022 •

edited

Loading

faisalramdan17 commented Mar 5, 2022 •

edited

Loading

Sunyuzu commented Mar 5, 2022 •

edited

Loading

K-Sato1995 commented Mar 6, 2022 •

edited

Loading

justingolden21 commented May 6, 2022 •

edited

Loading