Skip to content

Adapter build outputs are linted, formatted, and synced to Git #1832

Closed
@Nick-Mazuk

Description

Describe the bug

Build outputs to the adapters are not in the .eslintignore, .prettierignore, and .gitignore by default. This means they are linted, formatted, and checked into version control by default. I suspect this is not desired behavior for most people.

To Reproduce

  • Create any new Sveltekit project
  • Add an adapter (e.g., adapter-vercel)
  • pnpm build
  • Running pnpm lint, pnpm format, or git add . will now also include these new build outputs

To fix, you can just add the build output to the relevant ignore files. I think they should be there by default.

I can provide a reproduction repo, stack traces, etc. if needed, but I think the issue is fairly self-explanatory.

Expected behavior

By default, these files should not be linted, formatted, or checked into version control.

Severity

Honestly, not that severe. It's a ~30 second fix for anyone creating a Svekte/kit project. But the bug fix would also be a ~30 second fix as well.

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions