Skip to content

Don't bundle dependencies during build and remove noExternal default #1016

Closed
@benmccann

Description

@benmccann

A large portion of user issues are related to whether packages go in dependencies or devDependencies. This seems to be because of:

noExternal: Object.keys(pkg.dependencies || {})

noExternal means that Vite should bundle the packages. We added this line to have Vite bundle all the dependencies to make deployment to the serverless environments easy. At the moment, in most (if not all) of our adapters, we are using APIs which skip the platform bundling step. However, none of the serverless environments we use actually seem to require this. E.g. Vercel for example can do the bundle themselves using a different file structure. Netlify and Begin also look like they don't require us to bundle in the build step as we're doing today

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions