move some stuff out of client-facing code (#6557)

packages/kit/src/core/sync/create_manifest_data/index.js

@@ -103,6 +103,14 @@ function create_routes_and_nodes(cwd, config, fallback) {
 		 * @param {import('types').RouteData | null} parent
 		 */
 		const walk = (depth, id, segment, parent) => {
+			if (/\]\[/.test(id)) {
+				throw new Error(`Invalid route ${id} — parameters must be separated`);
+			}
+
+			if (count_occurrences('[', id) !== count_occurrences(']', id)) {
+				throw new Error(`Invalid route ${id} — brackets are unbalanced`);
+			}
+
 			const { pattern, names, types } = parse_route_id(id);
 
 			const segments = id.split('/');
@@ -450,3 +458,15 @@ function list_files(dir) {
 
 	return files;
 }
+
+/**
+ * @param {string} needle
+ * @param {string} haystack
+ */
+function count_occurrences(needle, haystack) {
+	let count = 0;
+	for (let i = 0; i < haystack.length; i += 1) {
+		if (haystack[i] === needle) count += 1;
+	}
+	return count;
+}

packages/kit/src/utils/routing.js

@@ -12,14 +12,6 @@ export function parse_route_id(id) {
 	// const add_trailing_slash = !/\.[a-z]+$/.test(key);
 	let add_trailing_slash = true;
 
-	if (/\]\[/.test(id)) {
-		throw new Error(`Invalid route ${id} — parameters must be separated`);
-	}
-
-	if (count_occurrences('[', id) !== count_occurrences(']', id)) {
-		throw new Error(`Invalid route ${id} — brackets are unbalanced`);
-	}
-
 	const pattern =
 		id === ''
 			? /^\/$/
@@ -123,15 +115,3 @@ export function exec(match, names, types, matchers) {
 
 	return params;
 }
-
-/**
- * @param {string} needle
- * @param {string} haystack
- */
-function count_occurrences(needle, haystack) {
-	let count = 0;
-	for (let i = 0; i < haystack.length; i += 1) {
-		if (haystack[i] === needle) count += 1;
-	}
-	return count;
-}