Skip to content

fix(sv): remove spread operator from ESLint config generation#971

Draft
sacrosanctic wants to merge 3 commits intosveltejs:mainfrom
sacrosanctic:running-weasel
Draft

fix(sv): remove spread operator from ESLint config generation#971
sacrosanctic wants to merge 3 commits intosveltejs:mainfrom
sacrosanctic:running-weasel

Conversation

@sacrosanctic
Copy link
Contributor

closes #967

@changeset-bot
Copy link

changeset-bot bot commented Mar 5, 2026

🦋 Changeset detected

Latest commit: 68cfa6d

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
sv Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@pkg-pr-new
Copy link

pkg-pr-new bot commented Mar 5, 2026

Open in StackBlitz

npx https://pkg.pr.new/svelte-migrate@971
npx https://pkg.pr.new/sv@971
npx https://pkg.pr.new/@sveltejs/sv-utils@971

commit: 7365055

@manuel3108
Copy link
Member

@sacrosanctic could you maybe have another look at this? Looks like the tests are failing because of this.

@svelte-docs-bot
Copy link

@sacrosanctic sacrosanctic marked this pull request as draft March 9, 2026 17:44
@sacrosanctic
Copy link
Contributor Author

do not merge!

i believe defineConfig should be used for js template as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

spread syntax in eslint's defineConfig is redundant

2 participants