Skip to content

fix: resolve to task instead of run in addon instructions for deno #599

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 20, 2025

Conversation

brunnerh
Copy link
Member

@brunnerh brunnerh commented Jun 20, 2025

Set up a project earlier and it output:

Run deno run db:push to update your database schema

...which is wrong for deno.

package-manager-detector seems to be used in other spots for this, so I added it here as well.
Tried to find all places using run, but only found it in lucia & drizzle.


Regarding changesets, I found this statement in CONTRIBUTING.md a bit confusing:

Only publish a change set if it is in 'sv' or 'svelte-migrate' as all other packages are bundled.

The changes are in addons but it affects sv...

Copy link

changeset-bot bot commented Jun 20, 2025

🦋 Changeset detected

Latest commit: 7972974

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 0 packages

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

pkg-pr-new bot commented Jun 20, 2025

Open in StackBlitz

npx https://pkg.pr.new/sveltejs/cli/sv@599
npx https://pkg.pr.new/sveltejs/cli/svelte-migrate@599

commit: 7972974

Copy link
Member

@manuel3108 manuel3108 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Totally makes sense, thank you!

@manuel3108 manuel3108 changed the title fix: Resolve to task instead of run in addon instructions for Deno. fix: resolve to task instead of run in addon instructions for deno Jun 20, 2025
@manuel3108 manuel3108 merged commit 30a022e into sveltejs:main Jun 20, 2025
4 of 6 checks passed
@github-actions github-actions bot mentioned this pull request Jun 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants