Skip to content

chore: unfork clack #526

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 16 commits into from
May 12, 2025
Merged

chore: unfork clack #526

merged 16 commits into from
May 12, 2025

Conversation

manuel3108
Copy link
Member

@manuel3108 manuel3108 commented Apr 6, 2025

Relates: bombshell-dev/clack#276

Thanks to @43081j for making this possible by submitting many PRs to the clack library.

This is WIP because

  • we currently rely on PR-build
  • taskLog is failing
  • a new format option will be provided to note so that we can get our current behavior back

Copy link

changeset-bot bot commented Apr 6, 2025

⚠️ No Changeset found

Latest commit: ebf692e

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

pkg-pr-new bot commented Apr 6, 2025

Open in StackBlitz

npx https://pkg.pr.new/sveltejs/cli/sv@526
npx https://pkg.pr.new/sveltejs/cli/svelte-migrate@526

commit: ebf692e

@43081j
Copy link
Contributor

43081j commented Apr 6, 2025

We also need an equivalent for cancel

I think I'll implement that as an option to outro in clack instead, i.e so you can set the level (success, warn, error)

Edit: ignore this, we do already support cancel 👍

@manuel3108
Copy link
Member Author

Yeah that sounds logical. Although at least typing-wise vscode is not complaining

@manuel3108
Copy link
Member Author

Looks like both relevant PR for clack have been merged, checking this

@43081j
Copy link
Contributor

43081j commented Apr 25, 2025

keep in mind we should still merge this first:

bombshell-dev/clack#251

so you have a real release instead of a pkg.pr.new one

ill see if i can sort that out this weekend

@svelte-docs-bot
Copy link

@manuel3108
Copy link
Member Author

Thats just what i was wondering about :D was searching for a non existing release. It's not that this has any time constraints, just wanted to clean up this PR because i nearly forgot about it

@manuel3108 manuel3108 marked this pull request as ready for review May 10, 2025 10:37
Copy link
Member

@AdrianGonz97 AdrianGonz97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is awesome! Thank you @43081j for all your work in getting this through!!

@manuel3108
Copy link
Member Author

Uhhh, nice trick!

@manuel3108 manuel3108 merged commit 30c09ac into main May 12, 2025
7 checks passed
@manuel3108 manuel3108 deleted the chore/unfork-clack branch May 12, 2025 15:43
@43081j
Copy link
Contributor

43081j commented May 12, 2025

awesome work :D

if we push any other useful stuff upstream ill let you know too

manuel3108 added a commit that referenced this pull request May 17, 2025
manuel3108 added a commit that referenced this pull request May 17, 2025
* Revert "chore: unfork clack (#526)"

This reverts commit 30c09ac.

* changeset

* remvoed unused import
@manuel3108 manuel3108 mentioned this pull request Jun 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants