-
-
Notifications
You must be signed in to change notification settings - Fork 45
chore: unfork clack #526
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: unfork clack #526
Conversation
|
commit: |
We also need an equivalent for I think I'll implement that as an option to Edit: ignore this, we do already support cancel 👍 |
Yeah that sounds logical. Although at least typing-wise vscode is not complaining |
Looks like both relevant PR for clack have been merged, checking this |
keep in mind we should still merge this first: so you have a real release instead of a pkg.pr.new one ill see if i can sort that out this weekend |
Thats just what i was wondering about :D was searching for a non existing release. It's not that this has any time constraints, just wanted to clean up this PR because i nearly forgot about it |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is awesome! Thank you @43081j for all your work in getting this through!!
Uhhh, nice trick! |
awesome work :D if we push any other useful stuff upstream ill let you know too |
This reverts commit 30c09ac.
Relates: bombshell-dev/clack#276
Thanks to @43081j for making this possible by submitting many PRs to the clack library.
This is WIP because
taskLog
is failingformat
option will be provided tonote
so that we can get our current behavior back