Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for creating tables #106

Merged
merged 97 commits into from
Mar 9, 2025
Merged

Support for creating tables #106

merged 97 commits into from
Mar 9, 2025

Conversation

sveinungf
Copy link
Owner

@sveinungf sveinungf commented Mar 8, 2025

Related to #63

Copy link

codecov bot commented Mar 8, 2025

Codecov Report

Attention: Patch coverage is 96.74797% with 20 lines in your changes missing coverage. Please review.

Project coverage is 92.38%. Comparing base (ca2d1ec) to head (12c5742).
Report is 98 commits behind head on main.

Files with missing lines Patch % Lines
SpreadCheetah/MetadataXml/Tables/TableXml.cs 95.77% 0 Missing and 6 partials ⚠️
SpreadCheetah/SpreadsheetBuffer.cs 76.47% 2 Missing and 2 partials ⚠️
...preadCheetah/Tables/Internal/WorksheetTableInfo.cs 95.23% 2 Missing and 2 partials ⚠️
SpreadCheetah/Worksheet.cs 90.24% 3 Missing and 1 partial ⚠️
...adCheetah/MetadataXml/Tables/TableColumnXmlPart.cs 98.36% 0 Missing and 1 partial ⚠️
SpreadCheetah/MetadataXml/WorksheetEndXml.cs 95.23% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #106      +/-   ##
==========================================
+ Coverage   91.78%   92.38%   +0.59%     
==========================================
  Files         149      162      +13     
  Lines        5492     6065     +573     
  Branches      917     1025     +108     
==========================================
+ Hits         5041     5603     +562     
- Misses        211      215       +4     
- Partials      240      247       +7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link

github-actions bot commented Mar 8, 2025

Test Results

     9 files  ±  0       9 suites  ±0   13m 0s ⏱️ +31s
 4 748 tests +198   4 748 ✅ +198  0 💤 ±0  0 ❌ ±0 
13 938 runs  +594  13 938 ✅ +594  0 💤 ±0  0 ❌ ±0 

Results for commit 12c5742. ± Comparison against base commit ca2d1ec.

This pull request removes 10 and adds 208 tests. Note that renamed tests count towards both.
SpreadCheetah.Test.Tests.SpreadsheetTests ‑ Spreadsheet_Finish_WorksheetWithAllFeaturesThatAffectWorksheetXml
SpreadCheetah.Test.Tests.SpreadsheetTests ‑ Spreadsheet_StartWorksheet_CorrectName(name: " With leading whitespace")
SpreadCheetah.Test.Tests.SpreadsheetTests ‑ Spreadsheet_StartWorksheet_CorrectName(name: "Exactly 31 Characters Long Name")
SpreadCheetah.Test.Tests.SpreadsheetTests ‑ Spreadsheet_StartWorksheet_CorrectName(name: "OneWord")
SpreadCheetah.Test.Tests.SpreadsheetTests ‑ Spreadsheet_StartWorksheet_CorrectName(name: "With trailing whitespace ")
SpreadCheetah.Test.Tests.SpreadsheetTests ‑ Spreadsheet_StartWorksheet_CorrectName(name: "With whitespace")
SpreadCheetah.Test.Tests.SpreadsheetTests ‑ Spreadsheet_StartWorksheet_CorrectName(name: "With'Single'Quotes")
SpreadCheetah.Test.Tests.SpreadsheetTests ‑ Spreadsheet_StartWorksheet_CorrectName(name: "With-Special-Characters!#¤%&")
SpreadCheetah.Test.Tests.SpreadsheetTests ‑ Spreadsheet_StartWorksheet_CorrectName(name: "WithNorwegianCharactersÆØÅ")
SpreadCheetah.Test.Tests.SpreadsheetTests ‑ Spreadsheet_StartWorksheet_CorrectName(name: "With\"Quotation\"Marks")
SpreadCheetah.SourceGenerator.Test.Tests.SpreadsheetTableTests ‑ Spreadsheet_Table_RowsFromSourceGeneratedCode
SpreadCheetah.Test.Tests.HeaderRowTests ‑ Spreadsheet_AddHeaderRow_HeaderLength(length: 255, activeTable: False)
SpreadCheetah.Test.Tests.HeaderRowTests ‑ Spreadsheet_AddHeaderRow_HeaderLength(length: 255, activeTable: True)
SpreadCheetah.Test.Tests.HeaderRowTests ‑ Spreadsheet_AddHeaderRow_HeaderLength(length: 256, activeTable: False)
SpreadCheetah.Test.Tests.HeaderRowTests ‑ Spreadsheet_AddHeaderRow_HeaderLength(length: 256, activeTable: True)
SpreadCheetah.Test.Tests.SpreadsheetTableTests ‑ Spreadsheet_Table_AddHeaderRowTwice
SpreadCheetah.Test.Tests.SpreadsheetTableTests ‑ Spreadsheet_Table_DataRowCellsWithStyle
SpreadCheetah.Test.Tests.SpreadsheetTableTests ‑ Spreadsheet_Table_DuplicateHeaderNames(differentCasing: False)
SpreadCheetah.Test.Tests.SpreadsheetTableTests ‑ Spreadsheet_Table_DuplicateHeaderNames(differentCasing: True)
SpreadCheetah.Test.Tests.SpreadsheetTableTests ‑ Spreadsheet_Table_DuplicateTableName
…

♻️ This comment has been updated with latest results.

@sveinungf sveinungf merged commit 582beb2 into main Mar 9, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant