Skip to content

Commit

Permalink
Don't warn on linelength from cpplint
Browse files Browse the repository at this point in the history
Summary:
Both clangformat and cpplint enforce line length. The former autofixes
but the latter doesn't. This means that when you `arc diff` the commit is autofixed
but the error from cpplint propogates down. Instead just rely on clangformat to
both enforce and autofix linelength.

Test Plan:
Edited some cpp files to make extra long lines. Ran arc lint. Verified
that clangformat autofixed the lines and cpplint didn't complain.

Reviewers: nserrino, zasgar, philkuz

Reviewed By: zasgar, philkuz

Signed-off-by: Vihang Mehta <vihang@pixielabs.ai>

Differential Revision: https://phab.corp.pixielabs.ai/D11163

GitOrigin-RevId: 33e7252
  • Loading branch information
vihangm authored and copybaranaut committed Apr 6, 2022
1 parent 4279750 commit 9b415dc
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion .arclint
Original file line number Diff line number Diff line change
Expand Up @@ -66,7 +66,7 @@
"--filter=-build/c++11",
"--filter=-build/c++14",
"--filter=-legal/copyright",
"--linelength=100"
"--filter=-whitespace/line_length"
]
},
"eslint-ui": {
Expand Down

0 comments on commit 9b415dc

Please sign in to comment.