refactor: remove unused code (#473)

github_app_should_limit_permissions can't be excluded.
suzuki-shunsuke · Jun 8, 2024 · 672d424 · 672d424
1 parent 28ded74
commit 672d424
Show file tree

Hide file tree

Showing 2 changed files with 1 addition and 52 deletions.
diff --git a/pkg/policy/github_app_should_limit_permissions.go b/pkg/policy/github_app_should_limit_permissions.go
@@ -19,7 +19,7 @@ func (p *GitHubAppShouldLimitPermissionsPolicy) ID() string {
 	return "010"
 }
 
-func (p *GitHubAppShouldLimitPermissionsPolicy) ApplyStep(logE *logrus.Entry, cfg *config.Config, stepCtx *StepContext, step *workflow.Step) (ge error) {
+func (p *GitHubAppShouldLimitPermissionsPolicy) ApplyStep(_ *logrus.Entry, _ *config.Config, _ *StepContext, step *workflow.Step) (ge error) {
 	action := p.checkUses(step.Uses)
 	if action == "" {
 		return nil
@@ -32,15 +32,6 @@ func (p *GitHubAppShouldLimitPermissionsPolicy) ApplyStep(logE *logrus.Entry, cf
 		}
 	}()
 
-	var name string
-	if stepCtx.Job != nil {
-		name = stepCtx.Job.Name
-	}
-	if p.excluded(cfg.Excludes, stepCtx.FilePath, name, step.ID) {
-		logE.Debug("this step is ignored")
-		return nil
-	}
-
 	if action == "tibdex/github-app-token" {
 		if step.With == nil {
 			return errPermissionsIsRequired
@@ -60,24 +51,3 @@ func (p *GitHubAppShouldLimitPermissionsPolicy) checkUses(uses string) string {
 	action, _, _ := strings.Cut(uses, "@")
 	return action
 }
-
-func (p *GitHubAppShouldLimitPermissionsPolicy) excluded(excludes []*config.Exclude, filePath, jobName, stepID string) bool {
-	for _, exclude := range excludes {
-		if exclude.PolicyName != p.Name() {
-			continue
-		}
-		if exclude.FilePath() != filePath {
-			continue
-		}
-		if jobName != "" {
-			if exclude.JobName != jobName {
-				continue
-			}
-		}
-		if exclude.StepID != stepID {
-			continue
-		}
-		return true
-	}
-	return false
-}
diff --git a/pkg/policy/github_app_should_limit_permissions_test.go b/pkg/policy/github_app_should_limit_permissions_test.go
@@ -44,27 +44,6 @@ func TestGitHubAppShouldLimitPermissionsPolicy_ApplyStep(t *testing.T) { //nolin
 				},
 			},
 		},
-		{
-			name: "exclude",
-			cfg: &config.Config{
-				Excludes: []*config.Exclude{
-					{
-						PolicyName:       "github_app_should_limit_permissions",
-						WorkflowFilePath: ".github/workflows/test.yaml",
-						JobName:          "test",
-						StepID:           "token",
-					},
-				},
-			},
-			step: &workflow.Step{
-				Uses: "tibdex/github-app-token@v2",
-				ID:   "token",
-				With: map[string]string{
-					"app_id":      "xxx",
-					"private_key": "xxx",
-				},
-			},
-		},
 	}
 	p := &policy.GitHubAppShouldLimitPermissionsPolicy{}
 	logE := logrus.NewEntry(logrus.New())