Only return error when strict is on or when the addr is not loopback

drainer/config.go

@@ -360,8 +360,12 @@ func validateAddr(addr string, strict bool) error {
 	}
 
 	if !util.IsValidateListenHost(host) {
-		if !(strict && host == "127.0.0.1") {
-			return errors.Errorf("pump may not be able to access drainer using this addr %s", addr)
+		err := errors.Errorf("pump may not be able to access drainer using this addr %s", addr)
+		if strict {
+			return err
+		}
+		if host != "127.0.0.1" && host != "localhost" {
+			return err
 		}
 	}
 	return nil

drainer/config_test.go

@@ -36,17 +36,19 @@ type testDrainerSuite struct{}
 
 func (t *testDrainerSuite) TestConfig(c *C) {
 	args := []string{
-		"-metrics-addr", "127.0.0.1:9091",
+		"-metrics-addr", "192.168.15.10:9091",
 		"-txn-batch", "1",
 		"-data-dir", "data.drainer",
 		"-dest-db-type", "mysql",
 		"-config", "../cmd/drainer/drainer.toml",
+		"-addr", "192.168.15.10:8257",
+		"-advertise-addr", "192.168.15.10:8257",
 	}
 
 	cfg := NewConfig()
 	err := cfg.Parse(args)
 	c.Assert(err, IsNil)
-	c.Assert(cfg.MetricsAddr, Equals, "127.0.0.1:9091")
+	c.Assert(cfg.MetricsAddr, Equals, "192.168.15.10:9091")
 	c.Assert(cfg.DataDir, Equals, "data.drainer")
 	c.Assert(cfg.SyncerCfg.TxnBatch, Equals, 1)
 	c.Assert(cfg.SyncerCfg.DestDBType, Equals, "mysql")
@@ -101,3 +103,14 @@ func (t *testDrainerSuite) TestAdjustConfig(c *C) {
 	c.Assert(cfg.SyncerCfg.WorkerCount, Equals, 1)
 	c.Assert(cfg.SyncerCfg.DisableDispatch, IsTrue)
 }
+
+type validateAddrSuite struct{}
+
+var _ = Suite(&validateAddrSuite{})
+
+func (s *validateAddrSuite) TestStrictOrNot(c *C) {
+	err := validateAddr("http://127.0.0.1:9090", true)
+	c.Assert(err, NotNil)
+	err = validateAddr("http://127.0.0.1:9090", false)
+	c.Assert(err, IsNil)
+}