fix: update logic to handle index of 0 #56
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…iews has changed.
|
Someone is attempting to deploy a commit to a Personal Account owned by @suyalcinkaya on Vercel. @suyalcinkaya first needs to authorize it. |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
suyalcinkaya
changed the title
suyalcinkaya
approved these changes
Jan 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi there,
I noticed that when the index equals 0, the update logic is not triggered, which seems incorrect.
The
if (index)check appears unnecessary and could be removed to fix this bug. Deleting that line would allow the update to correctly run even when index is 0.