Add thread safety #20
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey @kmewhort, thanks a lot for this cool improvement! I just set up Github Actions - can you rebase and verify the tests are all passing? |
sbiastoch
reviewed
Apr 8, 2022
Comment on lines
+26
to
+34
| execute <<~SQL | ||
| RESET rls.user_id; | ||
| RESET rls.tenant_id; | ||
| RESET rls.disable; | ||
| SQL | ||
|
|
||
| clear_query_cache | ||
|
|
||
| RLS.thread_rls_status.merge!(tenant_id: '', user_id: '', disabled: '') |
There was a problem hiding this comment.
Would it be possible to reuse here the existing RLS.reset! method (maybe with minor modifications) to not have this code duplicated here?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These changes should makes
rls_railsthread safe so that it can be used in multi-threaded applications -- such assidekiq,turbotests, etc.Specifically, this includes the following changes:
ActiveRecorduses the same connection pool between different threads, with the different threads checking out new connections from the pool.