Bhikkhu Pātimokkha (2nd) in Sarvastivada Vinaya is empty

[wcang]

Is there supposed to be any root text for the rules under https://suttacentral.net/lzh-sarv-bu-pm-2? I checked and I couldn't find any root text. If there is none, then Bhikkhu Patimokkha (2nd) should be completely removed.

Tagging @ayya-vimala

[ayya-vimala]

I found it in the sc-data backend ... will investigate.

[ayya-vimala]

The text is there in sc-data, all the right data is there in the sc-data/structure AND in bilara-data.

Yet, the text doesn't show up here: https://suttacentral.net/lzh-sarv-bu-pm-2 while its counterpart works as it should: https://suttacentral.net/lzh-sarv-bu-pm

What is going on here? @agilgur5 and @ihongda ?

[wcang]

Similarly, these are empty.
https://suttacentral.net/pitaka/vinaya/lzh-sarv-vi/lzh-sarv-bi-pm-dh
https://suttacentral.net/lzh-sarv-bu-kam
https://suttacentral.net/lzh-sarv-bu-kam-2
https://suttacentral.net/lzh-sarv-mt

[ayya-vimala]

Similarly, these are empty.
https://suttacentral.net/pitaka/vinaya/lzh-sarv-vi/lzh-sarv-bi-pm-dh
https://suttacentral.net/lzh-sarv-bu-kam
https://suttacentral.net/lzh-sarv-bu-kam-2
https://suttacentral.net/lzh-sarv-mt

I think this is different. Here the files are not on sc-data. These are just empty suttaplex cards, which is fine in SC. But if the text is on CBETA somewhere we can add it.

[wcang]

The two kammavacas that follow immediately are:
https://cbetaonline.dila.edu.tw/en/T1438_001
https://cbetaonline.dila.edu.tw/en/T1439_001

I'm not sure if the first one belongs to Sarvatisvada because there is no clear indication on the title. The second one is clearly Sarvastivada (十誦). As for the rest, I am not knowledgeable enough to make any suggestion.

[agilgur5]

What is going on here? @agilgur5 and @ihongda ?

@ihongda is away on holiday till later next week.

And in this case, I'm a bit out of my depth and I think you know how the structure works substantially better than me, so I don't know that I can help debug more than you did 😅
Currently, I barely know how this part of the pipeline works for what is needed to display where (and barely know these texts or their acronyms, so takes my eyes a bit to navigate too).

The text is there in sc-data, all the right data is there in the sc-data/structure AND in bilara-data.

I can try to follow along for my own edification and perhaps to act as a secondary check:

1. The text in sc-data: /html_text/lzh/vinaya/lzh-sarv-bu-pm-2.html
   • PM1: /html_text/lzh/vinaya/lzh-sarv-bu-pm.html
2. IDs in sc-data/structure:
   • sect.json#L93
     • they end in -div here (?)
   • language.json#L58
     • they end in -div here too (?)
   • super_extra_info.json#L309
   • text_extra_info.json#L134634
     • only PM2 is here
     • This was only added recently in f4b9010, so may not have made it to the server yet
   • /tree/super-tree.json#L200
   • /tree/vinaya/lzh-sarv-bu-pm-2-tree.json
     • PM1: /tree/vinaya/lzh-sarv-bu-pm-tree.json
3. Names in bilara-data:
   • /root/misc/site/name/vinaya/lzh-sarv-bu-pm-2-name_root-misc-site.json
     • PM1: /root/misc/site/name/vinaya/lzh-sarv-bu-pm-name_root-misc-site.json
   • /translation/en/sujato/name/super-name_translation-en-sujato.json#L138
   • Plus DE translations and some partial ones in other languages afaict

Yet, the text doesn't show up here: https://suttacentral.net/lzh-sarv-bu-pm-2 while its counterpart works as it should: https://suttacentral.net/lzh-sarv-bu-pm

I did reproduce this as well.
Looking through DevTools, both requested suttaplexes and both seem to return similar data, i.e. both have the root text:

• https://suttacentral.net/api/suttaplex/lzh-sarv-bu-pm-2
• https://suttacentral.net/api/suttaplex/lzh-sarv-bu-pm
• I noticed they have the same "volpage": "T 1030c11" (?)

Same for navigation:

• https://suttacentral.net/api/navigation_data/lzh-sarv-bu-pm-2
• https://suttacentral.net/api/navigation_data/lzh-sarv-bu-pm

So that's strange that it's not showing it for PM2.
The HTML can be viewed fine:

• https://suttacentral.net/lzh-sarv-bu-pm-2/lzh/taisho (Taishō vol. 22 no. 1422b)
• https://suttacentral.net/lzh-sarv-bu-pm/lzh/taisho (Taishō vol. 23 no. 1436)

[agilgur5]

Looking through DevTools, both requested suttaplexes and both seem to return similar data, i.e. both have the root text:

This made me suspect it was actually a front-end bug, that it's just not displaying, and I think that actually might be correct, unexpectedly: https://github.com/suttacentral/suttacentral/blob/ac30f9c7dc07da9bafd2bf67027c5cbd33c5ee81/client/elements/suttaplex/sc-suttaplex-list.js#L123-L129

  isPatimokkha() {
    return this.categoryId?.endsWith('-pm');
  }

  isPatimokkhaRuleCategory(uid) {
    return uid?.includes('-pm-');
  }

pm-2 doesn't match the first check, and does match the second. This changes the display logic in a few places, in particular: https://github.com/suttacentral/suttacentral/blob/ac30f9c7dc07da9bafd2bf67027c5cbd33c5ee81/client/elements/suttaplex/sc-suttaplex-list.js#L529-L531

            (this.isPatimokkha() && !this.isPatimokkhaRuleCategory(item.uid))
              ? this.suttaplexTemplate(item)
              : this.sectionTemplate(item)

If you look at the HTML tree on the page, there is no <sc-suttaplex> for PM2, instead there is <sc-suttaplex-section-title>

There's another component where it would fail the check too: https://github.com/suttacentral/suttacentral/blob/ac30f9c7dc07da9bafd2bf67027c5cbd33c5ee81/client/elements/navigation/sc-navigation.js#L303-L305

  _isPatimokkha(uid) {
    return uid.endsWith('-pm');
  }

These originate from suttacentral/suttacentral#2271, suttacentral/suttacentral#2013

There's also one similar back-end function: https://github.com/suttacentral/suttacentral/blob/ac30f9c7dc07da9bafd2bf67027c5cbd33c5ee81/server/src/api/views/views.py#L1791-L1792

    def is_patimokkha(self, uid):
        return uid.find('-pm') > -1

Both should match that though