fix FLOOR behavior for values of "significance" that are not powers o… #65
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…f 10
#63 fixed a bug in CEILING. I realized FLOOR has the same problem. this PR fixes it
some code cleanliness changes, in addition:
mode = (mode === undefined) ? 0 : mode
instead ofmode || 0
since checking truthiness of numbers is kind of an antipattern!(number > 0 && significance > 0) && !(number < 0 && significance < 0)
for consistency for CEILING, which just silently takes the absolute value of significanceexports.FLOOR.MATH = exports.FLOOR
to be consistent with CEILING.MATHmode === undefined
check after we've already parsed it as number