Fix base 10 as default for LOG function #58
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @Y--, would it be possible to tag a new minor release (1.0.9)? This would allow to have a new version on CNDJs: https://cdnjs.com/libraries/formulajs Thanks in advance. |
|
Done |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to Excel documentation LOG should be calculated with base 10 if omitted.
https://support.office.com/en-us/article/LOG-function-4E82F196-1CA9-4747-8FB0-6C4A3ABB3280
This feature was already implemented but was not correctly working.
Can you please create a minor release afterward to have an update of the CDN?