fix(prom): remove unused PROM_ configs #515
Merged
+7
−18
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sthaha
force-pushed
the
remove-prom-headers
branch
from
bbc0972 to
45eccd8
Compare
This commit removes the following * PROM_QUERY_START_TIME, PROM_QUERY_END_TIME since the config is only used in kepler_model main.py to be used as default values. * PROM_HEADERS: since the current format is a `str` and the expected format for headers is `dict[str, str]` for header: value to be set in http requests. This is removed until get_config can handle parsing str -> dict[str, str] Signed-off-by: Sunil Thaha <sthaha@redhat.com>
sthaha
force-pushed
the
remove-prom-headers
branch
from
45eccd8 to
9012b70
Compare
rootfs
approved these changes
Oct 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit removes the following
PROM_QUERY_START_TIME, PROM_QUERY_END_TIME since the config is only used in kepler_model main.py to be used as default values.
PROM_HEADERS: since the current format is a
strand the expected format for headers isdict[str, str]for header: value to be set in http requests. This is removed until get_config can handle parsing str -> dict[str, str]Checklist for PR Author
In addition to approval, the author must confirm the following check list:
Run the following command to format your code:
Create issues for unresolved comments and link them to this PR. Use one of the following labels:
must-fix: The logic appears incorrect and must be addressed.minor: Typos, minor issues, or potential refactoring for better readability.nit: Trivial issues like extra spaces, commas, etc.